[PATCH -tip] tracing: remove unused code

[PATCH -tip] tracing: remove unused code

[Luis Henriques]

struct file_operations tracing_lt_fops and tracing_lt_open are not used
anywhere.  These are legacy from the /debug/tracing/latency_trace, which has
been removed in commit 886b5b73d71e4027d7dc6c14f5f7ab102201ea6b

Signed-off-by: Luis Henriques <henrix@sapo.pt>
---
 kernel/trace/trace.c |   22 ----------------------
 1 files changed, 0 insertions(+), 22 deletions(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 5db7485..04306a1 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -1822,21 +1822,6 @@ static int tracing_open(struct inode *inode, struct file *file)
 	return ret;
 }
 
-static int tracing_lt_open(struct inode *inode, struct file *file)
-{
-	struct trace_iterator *iter;
-	int ret = 0;
-
-	iter = __tracing_open(inode, file);
-
-	if (IS_ERR(iter))
-		ret = PTR_ERR(iter);
-	else
-		iter->iter_flags |= TRACE_FILE_LAT_FMT;
-
-	return ret;
-}
-
 
 static void *
 t_next(struct seq_file *m, void *v, loff_t *pos)
@@ -1916,13 +1901,6 @@ static struct file_operations tracing_fops = {
 	.release	= tracing_release,
 };
 
-static struct file_operations tracing_lt_fops = {
-	.open		= tracing_lt_open,
-	.read		= seq_read,
-	.llseek		= seq_lseek,
-	.release	= tracing_release,
-};
-
 static struct file_operations show_traces_fops = {
 	.open		= show_traces_open,
 	.read		= seq_read,
-- 
1.6.1.3

Re: [PATCH -tip] tracing: remove unused code

[Steven Rostedt]

Thanks Luis,

But before I remove this code, I want to move it to be activated by 
tracing options. The irqsoff tracer (and other latency tracers) are pretty 
useless without it.

-- Steve


On Fri, 27 Feb 2009, Luis Henriques wrote:

> struct file_operations tracing_lt_fops and tracing_lt_open are not used
> anywhere.  These are legacy from the /debug/tracing/latency_trace, which has
> been removed in commit 886b5b73d71e4027d7dc6c14f5f7ab102201ea6b
> 
> Signed-off-by: Luis Henriques <henrix@sapo.pt>
> ---
>  kernel/trace/trace.c |   22 ----------------------
>  1 files changed, 0 insertions(+), 22 deletions(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 5db7485..04306a1 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -1822,21 +1822,6 @@ static int tracing_open(struct inode *inode, struct file *file)
>  	return ret;
>  }
>  
> -static int tracing_lt_open(struct inode *inode, struct file *file)
> -{
> -	struct trace_iterator *iter;
> -	int ret = 0;
> -
> -	iter = __tracing_open(inode, file);
> -
> -	if (IS_ERR(iter))
> -		ret = PTR_ERR(iter);
> -	else
> -		iter->iter_flags |= TRACE_FILE_LAT_FMT;
> -
> -	return ret;
> -}
> -
>  
>  static void *
>  t_next(struct seq_file *m, void *v, loff_t *pos)
> @@ -1916,13 +1901,6 @@ static struct file_operations tracing_fops = {
>  	.release	= tracing_release,
>  };
>  
> -static struct file_operations tracing_lt_fops = {
> -	.open		= tracing_lt_open,
> -	.read		= seq_read,
> -	.llseek		= seq_lseek,
> -	.release	= tracing_release,
> -};
> -
>  static struct file_operations show_traces_fops = {
>  	.open		= show_traces_open,
>  	.read		= seq_read,
> -- 
> 1.6.1.3
> 
> 

Re: [PATCH -tip] tracing: remove unused code

[Ingo Molnar]

* Steven Rostedt <rostedt@goodmis.org> wrote:

> Thanks Luis,
> 
> But before I remove this code, I want to move it to be 
> activated by tracing options. The irqsoff tracer (and other 
> latency tracers) are pretty useless without it.

sounds good.

	Ingo

Re: [PATCH -tip] tracing: remove unused code

[Luis Henriques]

On Sat, Feb 28, 2009 at 08:21:37AM +0100, Ingo Molnar wrote:
> 
> * Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > Thanks Luis,
> > 
> > But before I remove this code, I want to move it to be 
> > activated by tracing options. The irqsoff tracer (and other 
> > latency tracers) are pretty useless without it.
> 
> sounds good.

Ok, understood.  I am sorry for the noise introduced by this patch... I should
have got some more context before submitting it -- I am really not that familiar
with this code and tried just to remove a compile warning without fully
understand the whole picture :-)

-- 
Luis Henriques

Re: [PATCH -tip] tracing: remove unused code

[Frederic Weisbecker]

On Sat, Feb 28, 2009 at 07:40:04PM +0000, Luis Henriques wrote:
> On Sat, Feb 28, 2009 at 08:21:37AM +0100, Ingo Molnar wrote:
> > 
> > * Steven Rostedt <rostedt@goodmis.org> wrote:
> > 
> > > Thanks Luis,
> > > 
> > > But before I remove this code, I want to move it to be 
> > > activated by tracing options. The irqsoff tracer (and other 
> > > latency tracers) are pretty useless without it.
> > 
> > sounds good.
> 
> Ok, understood.  I am sorry for the noise introduced by this patch... I should
> have got some more context before submitting it -- I am really not that familiar
> with this code and tried just to remove a compile warning without fully
> understand the whole picture :-)


Don't be sorry, the fix was right.
But nobody can be aware of all background history in a subsystem, unless one read
all tracing related posts but it is very active these time so it can be a little pain for
a newcomer.

 
> -- 
> Luis Henriques
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/