From: Mark Brown <broonie@sirena.org.uk>
To: Theodore Tso <tytso@mit.edu>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Warn on empty commit log bodies
Date: Sun, 1 Mar 2009 00:46:19 +0000 [thread overview]
Message-ID: <20090301004618.GA12909@sirena.org.uk> (raw)
In-Reply-To: <20090301001829.GA10751@mit.edu>
On Sat, Feb 28, 2009 at 07:18:29PM -0500, Theodore Tso wrote:
> Just to shut up checkpatch, I'm going to feel the urge to shake a
> checkpatch maintainer warmly by the throat.
> Sometimes, all that is needed is:
> ------------
> ext4: Fix spelling error: successfull
>
> Signed-off-by: "Trivial Patch Submitter" <spelling@nits.org>
> ------------
As I've said already I pretty much agree with this.
The reason I sent the patch was that sending changelogs like that for
trivial changes is getting me negative feedback and I'm seeing other
comments about "unchangeloged patches" on the lists so I'm pretty sure
it's not just something I'm doing. I'm not saying I'm always blameless
here but when people are using terms like like "unchangeloged" it really
does suggest that one line changelogs are just considered not to have
changelogs.
Some consistency would be good here.
next prev parent reply other threads:[~2009-03-01 0:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-27 18:05 [PATCH] checkpatch: Warn on empty commit log bodies Mark Brown
2009-02-28 13:58 ` Stefan Richter
2009-02-28 15:58 ` Mark Brown
2009-02-28 16:14 ` Stefan Richter
2009-02-28 16:46 ` Mark Brown
2009-02-28 17:33 ` Stefan Richter
2009-02-28 17:52 ` Mark Brown
2009-02-28 19:25 ` Stefan Richter
2009-02-28 21:02 ` Mark Brown
2009-02-28 23:01 ` Stefan Richter
2009-03-01 0:18 ` Theodore Tso
2009-03-01 0:46 ` Mark Brown [this message]
2009-03-01 2:53 ` Theodore Tso
2009-03-02 13:15 ` Mark Brown
2009-03-02 15:15 ` Stefan Richter
2009-03-02 16:01 ` Mark Brown
2009-03-02 18:01 ` Andrew Morton
2009-03-02 18:24 ` Mark Brown
2009-03-02 18:34 ` Andrew Morton
2009-03-02 18:43 ` Theodore Tso
2009-03-02 19:19 ` Mark Brown
2009-03-02 19:57 ` Theodore Tso
2009-03-02 20:38 ` Mark Brown
2009-03-10 18:19 ` Andy Whitcroft
2009-02-28 17:40 ` Arjan van de Ven
2009-02-28 17:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090301004618.GA12909@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox