From: David Brownell <david-b@pacbell.net>
To: Balaji Rao <balajirrao@openmoko.org>
Cc: linux-kernel@vger.kernel.org,
spi-devel-general@lists.sourceforge.net,
Andy Green <andy@openmoko.com>
Subject: Re: [PATCH 0/2] spi: Add support for non-blocking synchronous transfers
Date: Sun, 1 Mar 2009 01:49:19 -0800 [thread overview]
Message-ID: <200903010149.19845.david-b@pacbell.net> (raw)
In-Reply-To: <20090301051103.GA3103@fedora.yogi>
On Saturday 28 February 2009, Balaji Rao wrote:
> > That leaves un-answered the question of what to do when
> > the SPI bus is busy performing some other transfer. I
> > looked at your [2/2] patch, and saw it ignoring that very
> > basic issue ... this new call will just poke at the bus,
> > trashing any transfer that was ongoing.
>
> We use s3c24xx_gpio as the master, which is a very simple gpio based
> bitbang.
>
> Yes, it is with this intention, interrupts are disabled around the
> actual bitbang code, so that it completes without being interrupted.
> Doesn't this guarantee atomicity ?
Atomicity isn't the issue so much as the fact that if the
bus is in the middle of some transfer to one device,
your patch lets another device trash that transmission.
I don't know how many more times I can say that your
patches introduce DATA CORRUPTION to the system, but
it's surely not many more times.
next prev parent reply other threads:[~2009-03-01 9:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-28 8:10 [PATCH 0/2] spi: Add support for non-blocking synchronous transfers Balaji Rao
2009-02-28 8:10 ` [PATCH 1/2] " Balaji Rao
2009-02-28 8:11 ` [PATCH 2/2] spi_bitbang: " Balaji Rao
2009-02-28 9:09 ` Simon Kagstrom
2009-02-28 9:58 ` Balaji Rao
2009-02-28 10:15 ` Simon Kagstrom
2009-02-28 10:59 ` Balaji Rao
2009-02-28 20:33 ` [PATCH 0/2] spi: " David Brownell
2009-02-28 22:12 ` Balaji Rao
2009-02-28 23:19 ` David Brownell
2009-03-01 5:11 ` Balaji Rao
2009-03-01 9:49 ` David Brownell [this message]
2009-03-01 10:23 ` Balaji Rao
2009-03-01 7:48 ` Andy Green
2009-03-01 9:43 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903010149.19845.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=andy@openmoko.com \
--cc=balajirrao@openmoko.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox