public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: Mark Brown <broonie@sirena.org.uk>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
	Andy Whitcroft <apw@canonical.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Warn on empty commit log bodies
Date: Sat, 28 Feb 2009 21:53:57 -0500	[thread overview]
Message-ID: <20090301025357.GC10751@mit.edu> (raw)
In-Reply-To: <20090301004618.GA12909@sirena.org.uk>

On Sun, Mar 01, 2009 at 12:46:19AM +0000, Mark Brown wrote:
> 
> The reason I sent the patch was that sending changelogs like that for
> trivial changes is getting me negative feedback and I'm seeing other
> comments about "unchangeloged patches" on the lists so I'm pretty sure
> it's not just something I'm doing.  I'm not saying I'm always blameless
> here but when people are using terms like like "unchangeloged" it really
> does suggest that one line changelogs are just considered not to have
> changelogs.

Well, I certainly don't have a problem with this.  I in fact get
*really* *annoyed* when I get patch submissions where the subject line
is replicated in the body, since I then have to manually edit the mail
message before I can run "git am" on the mail message.

Who's been complaining?  I can certainly tell you I'll complain in the
opposite direction, but that's because it actually causes me more work
as a maintainer.  If people are kvetching, maybe they should complain
to git mailing list and ask for a different git commit to e-mail
message convention --- but it's really not hard to look at the subject
line.

						- Ted

  reply	other threads:[~2009-03-01  2:54 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-27 18:05 [PATCH] checkpatch: Warn on empty commit log bodies Mark Brown
2009-02-28 13:58 ` Stefan Richter
2009-02-28 15:58   ` Mark Brown
2009-02-28 16:14     ` Stefan Richter
2009-02-28 16:46       ` Mark Brown
2009-02-28 17:33         ` Stefan Richter
2009-02-28 17:52           ` Mark Brown
2009-02-28 19:25             ` Stefan Richter
2009-02-28 21:02               ` Mark Brown
2009-02-28 23:01                 ` Stefan Richter
2009-03-01  0:18                   ` Theodore Tso
2009-03-01  0:46                     ` Mark Brown
2009-03-01  2:53                       ` Theodore Tso [this message]
2009-03-02 13:15                         ` Mark Brown
2009-03-02 15:15                           ` Stefan Richter
2009-03-02 16:01                             ` Mark Brown
2009-03-02 18:01                             ` Andrew Morton
2009-03-02 18:24                               ` Mark Brown
2009-03-02 18:34                                 ` Andrew Morton
2009-03-02 18:43                                   ` Theodore Tso
2009-03-02 19:19                                   ` Mark Brown
2009-03-02 19:57                                     ` Theodore Tso
2009-03-02 20:38                                       ` Mark Brown
2009-03-10 18:19                     ` Andy Whitcroft
2009-02-28 17:40 ` Arjan van de Ven
2009-02-28 17:47   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090301025357.GC10751@mit.edu \
    --to=tytso@mit.edu \
    --cc=apw@canonical.com \
    --cc=broonie@sirena.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox