From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Murphy <mamurph@cs.clemson.edu>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-usb@vger.kernel.org, greg@kroah.com, oliver@neukum.org,
fweisbec@gmail.com, torvalds@linux-foundation.org
Subject: Re: PATCH [1/3] drivers/input/xpad.c: Improve Xbox 360 wireless support and add sysfs interface
Date: Mon, 2 Mar 2009 14:00:14 -0800 [thread overview]
Message-ID: <20090302140014.47b60178.akpm@linux-foundation.org> (raw)
In-Reply-To: <5aa163d00903021346g59d90241v11f384eb97641e43@mail.gmail.com>
On Mon, 2 Mar 2009 16:46:01 -0500
Mike Murphy <mamurph@cs.clemson.edu> wrote:
> I had looked up another driver that used a header file in the stable
> tree
Yup, there's lots of crappy code in the tree, and it is regrettable
that maintainers continue to go ahead and merge that crappy code.
There's no easy fix for this - you need to be aware of what is right
and what is wrong, but you cannot look at existing code to determine
this :(
If the code which you're modifying is known (by you) to be wrong then
there are two schools of thought. Some people do like to "match the
existing code". I disagree with that. The code's wrong dammit - we
might as well make the new code "right". If that results in
inconsistent-looking code, well, so be it. We shouldn't have merged
the wrong code in the first place.
next prev parent reply other threads:[~2009-03-02 22:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-01 4:53 PATCH [1/3] drivers/input/xpad.c: Improve Xbox 360 wireless support and add sysfs interface Mike Murphy
2009-03-02 21:04 ` Andrew Morton
2009-03-02 21:18 ` Greg KH
2009-03-02 21:35 ` Andrew Morton
2009-03-02 21:59 ` Greg KH
2009-03-02 21:59 ` Mike Murphy
2009-03-02 22:39 ` Greg KH
2009-03-02 23:04 ` Mike Murphy
2009-03-02 23:13 ` Greg KH
2009-03-02 21:46 ` Mike Murphy
2009-03-02 22:00 ` Andrew Morton [this message]
2009-03-02 22:27 ` Mike Murphy
2009-03-03 2:47 ` Mike Murphy
2009-03-03 3:09 ` Mike Murphy
2009-03-03 3:12 ` Linus Torvalds
2009-03-03 4:16 ` Mike Murphy
2009-03-03 4:20 ` Mike Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090302140014.47b60178.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=greg@kroah.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mamurph@cs.clemson.edu \
--cc=oliver@neukum.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox