From: Andrew Morton <akpm@linux-foundation.org>
To: djwong@us.ibm.com
Cc: khali@linux-fr.org, linux-kernel@vger.kernel.org,
lm-sensors@lm-sensors.org
Subject: Re: [PATCH] lm90: Support the MAX6648/6692 chips
Date: Mon, 2 Mar 2009 15:04:26 -0800 [thread overview]
Message-ID: <20090302150426.b22100c1.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090302210106.GD6550@plum>
On Mon, 2 Mar 2009 13:01:06 -0800
"Darrick J. Wong" <djwong@us.ibm.com> wrote:
> @@ -776,7 +776,12 @@ static int lm90_detect(struct i2c_client *new_client, int kind,
> && (reg_config1 & 0x3f) == 0x00
> && reg_convrate <= 0x07) {
> kind = max6646;
> - }
> + } else
> + /* The MAX6648/6692 chips have a working man/chip id
> + * and the same register set as the 6657.
> + */
> + if (chip_id == 0x59 && address == 0x4C)
> + kind = max6657;
> }
gack, the indenting and layout there is totally busted.
--- a/drivers/hwmon/lm90.c~lm90-support-the-max6648-6692-chips-fix
+++ a/drivers/hwmon/lm90.c
@@ -776,12 +776,14 @@ static int lm90_detect(struct i2c_client
&& (reg_config1 & 0x3f) == 0x00
&& reg_convrate <= 0x07) {
kind = max6646;
- } else
- /* The MAX6648/6692 chips have a working man/chip id
- * and the same register set as the 6657.
- */
- if (chip_id == 0x59 && address == 0x4C)
+ } else if (chip_id == 0x59 && address == 0x4C) {
+ /*
+ * The MAX6648/6692 chips have a working
+ * man/chip id and the same register set as the
+ * 6657.
+ */
kind = max6657;
+ }
}
if (kind <= 0) { /* identification failed */
_
next prev parent reply other threads:[~2009-03-02 23:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 21:01 [PATCH] lm90: Support the MAX6648/6692 chips Darrick J. Wong
2009-03-02 23:04 ` Andrew Morton [this message]
2009-03-03 7:47 ` Jean Delvare
2009-03-03 8:04 ` Andrew Morton
2009-03-04 15:27 ` Jean Delvare
2009-03-02 23:07 ` Andrew Morton
2009-03-04 15:28 ` Jean Delvare
2009-03-05 14:25 ` Jean Delvare
2009-03-05 15:47 ` Darrick J. Wong
2009-03-05 16:44 ` Jean Delvare
2009-03-05 17:37 ` [PATCH] lm90: Document support for " Darrick J. Wong
2009-03-05 18:01 ` Jean Delvare
2009-03-05 17:58 ` [PATCH] lm90: Update Documentation/hwmon/lm90 to reflect max6648/92 support Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090302150426.b22100c1.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=djwong@us.ibm.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox