From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
lkml <linux-kernel@vger.kernel.org>,
"linux-arch" <linux-arch@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC][PATCH] irq: remove IRQF_DISABLED
Date: Mon, 2 Mar 2009 19:27:22 +0100 [thread overview]
Message-ID: <200903021927.22781.bzolnier@gmail.com> (raw)
In-Reply-To: <1236017249.5330.1011.camel@laptop>
On Monday 02 March 2009, Peter Zijlstra wrote:
> On Mon, 2009-03-02 at 18:55 +0100, Bartlomiej Zolnierkiewicz wrote:
> > > Could we make just the IDE driver itself enable interrupts? Sure. But that
> >
> > Actually it has been doing it for years (some host drivers don't do this by
> > default and still need "hdparm -u" or equivalent but I was planning to change
> > it for 2.6.30).
>
> What does it use to do that? A local_irq_enable() in hardirq context
> will make lockdep yell bloody murder :-).
>
> Then there is local_irq_enable_in_hardirq(), which plain simply lies
> when lockdep is enabled -- IOW it would generate horrid irq latencies.
>
> Not having to deal with IRQ recursion in lockdep helps.
Lockdep problems are the least of our worries here (please read Linus'
original mail for details). If you're asking why it is not handled in
softirq -- that's solely because of the historical reasons and I have
high hopes w.r.t. threaded IRQs work here [that it will allow us to
address this issue without too much pain].
Thanks,
Bart
next prev parent reply other threads:[~2009-03-02 18:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 12:21 [RFC][PATCH] irq: remove IRQF_DISABLED Peter Zijlstra
2009-03-02 14:43 ` Ingo Molnar
2009-03-02 15:47 ` Matthew Wilcox
2009-03-02 15:59 ` Peter Zijlstra
2009-03-02 16:32 ` Matthew Wilcox
2009-03-02 21:01 ` Russell King
2009-03-02 21:17 ` Ingo Molnar
2009-03-02 17:11 ` Linus Torvalds
2009-03-02 17:55 ` Bartlomiej Zolnierkiewicz
2009-03-02 18:02 ` Peter Zijlstra
2009-03-02 18:07 ` Peter Zijlstra
2009-03-02 18:27 ` Bartlomiej Zolnierkiewicz [this message]
2009-03-02 18:29 ` Linus Torvalds
2009-03-02 18:48 ` Bartlomiej Zolnierkiewicz
2009-03-02 19:06 ` Linus Torvalds
2009-03-02 19:18 ` Bartlomiej Zolnierkiewicz
2009-03-02 17:56 ` Peter Zijlstra
2009-03-02 18:45 ` Vadim Lobanov
2009-03-02 18:54 ` Linus Torvalds
2009-03-05 15:40 ` Mark Lord
2009-03-02 21:17 ` Alan Cox
2009-03-06 8:58 ` Benjamin Herrenschmidt
2009-03-06 9:12 ` Peter Zijlstra
2009-03-06 9:59 ` Benjamin Herrenschmidt
2009-03-06 10:05 ` Benjamin Herrenschmidt
2009-03-06 10:24 ` Peter Zijlstra
2009-03-06 17:02 ` Peter Zijlstra
2009-03-06 21:40 ` Benjamin Herrenschmidt
2009-03-02 17:55 ` Andrew Morton
2009-03-02 18:10 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903021927.22781.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).