public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Langsdorf, Mark" <mark.langsdorf@amd.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, tglx@linutronix.de,
	eric@lammerts.org
Subject: Re: [PATCH][retry 2] Conform L3 Cache Index Disable to Linuxstandards From:  Eric Lammerts <eric@lammerts.org>
Date: Mon, 2 Mar 2009 21:02:13 +0100	[thread overview]
Message-ID: <20090302200213.GA13699@elte.hu> (raw)
In-Reply-To: <6453C3CB8E2B3646B0D020C112613273C5AEF2@sausexmb4.amd.com>


* Langsdorf, Mark <mark.langsdorf@amd.com> wrote:

> > > > Add ABI Documentation entry and fix some /sys directory formating
> > > > issues with the L3 Cache Index Disable feature for future AMD
> > > > processors. __Add a check to disable it for family 0x10 models
> > > > that do not support it yet.
> > > 
> > > x86_64 allnoconfig:
> > > 
> > > arch/x86/kernel/cpu/intel_cacheinfo.c:556: warning: 
> > 'free_cache_attributes' defined but not used
> > > arch/x86/kernel/cpu/intel_cacheinfo.c:596: warning: 
> > 'detect_cache_attributes' defined but not used
> 
> My code doesn't modify either of these functions, so
> I'm not causing the regression.

The more serious problem is what i reported, that your patch 
triggers this build failure:

arch/x86/kernel/built-in.o: In function `store_cache_disable':
intel_cacheinfo.c:(.text+0xd322): undefined reference to `k8_northbridges'
arch/x86/kernel/built-in.o: In function `show_cache_disable':
intel_cacheinfo.c:(.text+0xd52c): undefined reference to `k8_northbridges'

so i've excluded it from tip:master for now. Please resubmit a 
fixed patch.

	Ingo

  reply	other threads:[~2009-03-02 20:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-20 21:50 [PATCH][retry 2] Conform L3 Cache Index Disable to Linux standards From: Eric Lammerts <eric@lammerts.org> Mark Langsdorf
2009-02-20 22:46 ` Andrew Morton
2009-02-27  0:33 ` Andrew Morton
2009-02-27  8:02   ` Ingo Molnar
2009-03-02 16:44     ` [PATCH][retry 2] Conform L3 Cache Index Disable to Linuxstandards " Langsdorf, Mark
2009-03-02 20:02       ` Ingo Molnar [this message]
2009-03-03 22:14         ` [PATCH][retry 3] " Mark Langsdorf
2009-03-03 22:22           ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090302200213.GA13699@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=eric@lammerts.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.langsdorf@amd.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox