Re: [PATCH 08/19] Simplify the check on whether cpusets are a factor or not

Christoph Lameter
2009-02-24T17:35:54Z

On Tue, 24 Feb 2009, Mel Gorman wrote:

> @@ -1420,8 +1429,8 @@ zonelist_scan:
> if (NUMA_BUILD && zlc_active &&
> !zlc_zone_worth_trying(zonelist, z, allowednodes))
> continue;
> - if ((alloc_flags & ALLOC_CPUSET) &&
> - !cpuset_zone_allowed_softwall(zone, gfp_mask))
> + if (alloc_cpuset)
> + if (!cpuset_zone_allowed_softwall(zone, gfp_mask))
> goto try_next_zone;

Hmmm... Why remove the && here? Looks more confusing to me.