From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Hans-Christian Egtvedt <hcegtvedt@atmel.com>
Subject: Re: [PATCH 2/2] Input: add wm97xx accelerated driver for AVR32 AT32AP700X microprocessors
Date: Tue, 3 Mar 2009 10:35:02 +0000 [thread overview]
Message-ID: <20090303103501.GA19086@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20090303091322.GA14557@dtor-d630.eng.vmware.com>
On Tue, Mar 03, 2009 at 01:13:23AM -0800, Dmitry Torokhov wrote:
> Hi Mark,
This is actually Hans-Christian's patch but here goes...
> > + if (!pressure && source == WM97XX_ADCSEL_Y) {
> > + input_report_abs(wm->input_dev, ABS_X, at32_wm97xx->x);
> > + input_report_abs(wm->input_dev, ABS_Y, at32_wm97xx->y);
> > + input_report_abs(wm->input_dev, ABS_PRESSURE, pen_down);
> Please do not report pressure (and don't advertise ABS_PRESSURE) if you don't
> actually read it. I have seen a follow-up patch that adds BTN_TOUCH that should
> work just fine here. The usage below is good since there you actually do provide
> true pressure readings. BTW, why would one not want pressure readings?
These parts are usually deployed in embedded systems where performance
is sufficiently tightly constrained that the additional work involved in
taking pressure measurements is noticable. This is mostly the case
where PIO is used but users have reported problems even when using DMA
so idiomatically WM97xx drivers provide the option.
next prev parent reply other threads:[~2009-03-03 10:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 13:23 [PATCH 1/2] Input: Accelerated touchscreen support for Marvell Zylonite Mark Brown
2009-03-02 13:23 ` [PATCH 2/2] Input: add wm97xx accelerated driver for AVR32 AT32AP700X microprocessors Mark Brown
2009-03-02 14:34 ` Jiri Slaby
2009-03-02 22:33 ` Jiri Slaby
2009-03-02 23:02 ` Mark Brown
2009-03-03 9:13 ` Dmitry Torokhov
2009-03-03 10:35 ` Mark Brown [this message]
2009-03-02 13:44 ` [PATCH 1/2] Input: Accelerated touchscreen support for Marvell Zylonite Jiri Slaby
2009-03-02 14:00 ` Mark Brown
2009-03-02 14:15 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090303103501.GA19086@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hcegtvedt@atmel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox