Re: [PATCH] Add to_delayed_work helper function

Ingo Molnar
2009-04-02T11:23:30Z

* Jean Delvare <khali@linux-fr.org> wrote:

> It is a fairly common operation to have a pointer to a work and to
> need a pointer to the delayed work it is contained in. In particular,
> all delayed works which want to rearm themselves will have to do that.
> So it would seem fair to offer a helper function for this operation.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Acked-by: Ingo Molnar <mingo@elte.hu>
> ---
> Patch updated to include new users. It would be nice to have this patch
> merged soon so that I no longer have to update it. Andrew?

Andrew, iff it's comprehensively build-tested then this should go
into .30 from -mm, right?

Because this:

> arch/powerpc/kernel/vio.c | 2 +-
> drivers/crypto/hifn_795x.c | 2 +-
> drivers/input/mouse/hgpk.c | 2 +-
> drivers/net/dm9000.c | 2 +-
> drivers/net/mlx4/en_netdev.c | 2 +-
> drivers/net/mlx4/en_rx.c | 2 +-
> drivers/net/mlx4/sense.c | 2 +-
> drivers/net/phy/phy.c | 3 +--
> drivers/s390/scsi/zfcp_fc.c | 2 +-
> drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c | 8 ++++----
> drivers/staging/rtl8187se/r8180_core.c | 8 ++++----
> drivers/staging/rtl8187se/r8180_dm.c | 6 +++---
> drivers/usb/wusbcore/devconnect.c | 2 +-
> include/linux/workqueue.h | 5 +++++
> mm/slab.c | 3 +--
> 15 files changed, 27 insertions(+), 24 deletions(-)

... will be painful to port across another cycle.

( and it's pointless to delay as well, this is an obvious cleanup
well in line with how we use to_*() container constructs elsewhere
in the driver frameworks. )

Ingo