From: Arun R Bharadwaj <arun@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org, linux-pm@lists.linux-foundation.org
Cc: a.p.zijlstra@chello.nl, ego@in.ibm.com, tglx@linutronix.de,
mingo@elte.hu, andi@firstfloor.org,
venkatesh.pallipadi@intel.com, vatsa@linux.vnet.ibm.com,
arjan@infradead.org, svaidy@linux.vnet.ibm.com,
Arun Bharadwaj <arun@linux.vnet.ibm.com>
Subject: [v2 PATCH 4/4] timers: logic to enable timer migration.
Date: Wed, 4 Mar 2009 17:49:37 +0530 [thread overview]
Message-ID: <20090304121937.GE9855@linux.vnet.ibm.com> (raw)
In-Reply-To: <20090304121249.GA9855@linux.vnet.ibm.com>
* Arun R Bharadwaj <arun@linux.vnet.ibm.com> [2009-03-04 17:42:49]:
This patch migrates all non pinned timers and hrtimers to the current
idle load balancer, from all the idle CPUs. Timers firing on busy CPUs
are not migrated.
Signed-off-by: Arun R Bharadwaj <arun@linux.vnet.ibm.com>
---
include/linux/sched.h | 1 +
kernel/hrtimer.c | 12 +++++++++++-
kernel/sched.c | 5 +++++
kernel/timer.c | 13 ++++++++++++-
4 files changed, 29 insertions(+), 2 deletions(-)
Index: linux.trees.git/kernel/timer.c
===================================================================
--- linux.trees.git.orig/kernel/timer.c
+++ linux.trees.git/kernel/timer.c
@@ -38,6 +38,7 @@
#include <linux/tick.h>
#include <linux/kallsyms.h>
#include <linux/timer.h>
+#include <linux/sched.h>
#include <asm/uaccess.h>
#include <asm/unistd.h>
@@ -628,7 +629,7 @@ __mod_timer(struct timer_list *timer, un
{
struct tvec_base *base, *new_base;
unsigned long flags;
- int ret;
+ int ret, current_cpu, preferred_cpu;
ret = 0;
@@ -649,6 +650,16 @@ __mod_timer(struct timer_list *timer, un
new_base = __get_cpu_var(tvec_bases);
+ current_cpu = smp_processor_id();
+ preferred_cpu = get_nohz_load_balancer();
+ if (enable_timer_migration && !tbase_get_pinned(timer->base) &&
+ idle_cpu(current_cpu) && preferred_cpu != -1) {
+ new_base = per_cpu(tvec_bases, preferred_cpu);
+ timer_set_base(timer, new_base);
+ timer->expires = expires;
+ internal_add_timer(new_base, timer);
+ goto out_unlock;
+ }
if (base != new_base) {
/*
* We are trying to schedule the timer on the local CPU.
Index: linux.trees.git/kernel/hrtimer.c
===================================================================
--- linux.trees.git.orig/kernel/hrtimer.c
+++ linux.trees.git/kernel/hrtimer.c
@@ -43,6 +43,8 @@
#include <linux/seq_file.h>
#include <linux/err.h>
#include <linux/debugobjects.h>
+#include <linux/sched.h>
+#include <linux/timer.h>
#include <asm/uaccess.h>
@@ -198,8 +200,16 @@ int pinned)
{
struct hrtimer_clock_base *new_base;
struct hrtimer_cpu_base *new_cpu_base;
+ int current_cpu, preferred_cpu;
+
+ current_cpu = smp_processor_id();
+ preferred_cpu = get_nohz_load_balancer();
+ if (enable_timer_migration && !pinned && preferred_cpu != -1 &&
+ idle_cpu(current_cpu))
+ new_cpu_base = &per_cpu(hrtimer_bases, preferred_cpu);
+ else
+ new_cpu_base = &__get_cpu_var(hrtimer_bases);
- new_cpu_base = &__get_cpu_var(hrtimer_bases);
new_base = &new_cpu_base->clock_base[base->index];
if (base != new_base) {
Index: linux.trees.git/include/linux/sched.h
===================================================================
--- linux.trees.git.orig/include/linux/sched.h
+++ linux.trees.git/include/linux/sched.h
@@ -265,6 +265,7 @@ static inline int select_nohz_load_balan
}
#endif
+extern int get_nohz_load_balancer(void);
/*
* Only dump TASK_* tasks. (0 for all tasks)
*/
Index: linux.trees.git/kernel/sched.c
===================================================================
--- linux.trees.git.orig/kernel/sched.c
+++ linux.trees.git/kernel/sched.c
@@ -4009,6 +4009,11 @@ static struct {
.load_balancer = ATOMIC_INIT(-1),
};
+inline int get_nohz_load_balancer(void)
+{
+ return atomic_read(&nohz.load_balancer);
+}
+
/*
* This routine will try to nominate the ilb (idle load balancing)
* owner among the cpus whose ticks are stopped. ilb owner will do the idle
next prev parent reply other threads:[~2009-03-04 12:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 12:12 [v2 PATCH 0/4] timers: framework for migration between CPU Arun R Bharadwaj
2009-03-04 12:14 ` [v2 PATCH 1/4] timers: framework to identify pinned timers Arun R Bharadwaj
2009-03-05 16:53 ` Oleg Nesterov
2009-03-06 6:14 ` Arun R Bharadwaj
2009-03-06 15:03 ` Oleg Nesterov
2009-03-06 7:01 ` Arun R Bharadwaj
2009-03-04 12:16 ` [v2 PATCH 2/4] timers: identifying the existing pinned hrtimers Arun R Bharadwaj
2009-03-04 12:18 ` [v2 PATCH 3/4] timers: sysfs hook to enable timer migration Arun R Bharadwaj
2009-03-04 12:19 ` Arun R Bharadwaj [this message]
2009-03-04 16:33 ` [v2 PATCH 4/4] timers: logic " Daniel Walker
2009-03-04 16:52 ` Arun R Bharadwaj
2009-03-05 15:34 ` Oleg Nesterov
2009-03-05 16:23 ` Oleg Nesterov
2009-03-06 3:21 ` Gautham R Shenoy
2009-03-06 14:50 ` Oleg Nesterov
2009-03-06 15:49 ` Gautham R Shenoy
2009-03-06 17:08 ` Oleg Nesterov
2009-03-06 17:26 ` Gautham R Shenoy
2009-03-04 17:33 ` [v2 PATCH 0/4] timers: framework for migration between CPU Ingo Molnar
2009-03-04 18:06 ` Vaidyanathan Srinivasan
2009-03-04 18:29 ` Ingo Molnar
2009-03-06 0:14 ` Arjan van de Ven
2009-03-06 4:23 ` Arun R Bharadwaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090304121937.GE9855@linux.vnet.ibm.com \
--to=arun@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=arjan@infradead.org \
--cc=ego@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@elte.hu \
--cc=svaidy@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=vatsa@linux.vnet.ibm.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox