From: Ingo Molnar <mingo@elte.hu>
To: Brian Maly <bmaly@redhat.com>
Cc: Yinghai Lu <yinghai@kernel.org>,
linux-kernel@vger.kernel.org, ying.huang@intel.com
Subject: Re: [PATCH] fix DMI for EFI
Date: Wed, 4 Mar 2009 19:02:55 +0100 [thread overview]
Message-ID: <20090304180255.GC1537@elte.hu> (raw)
In-Reply-To: <49AEC1CA.50405@redhat.com>
* Brian Maly <bmaly@redhat.com> wrote:
>> Your patch looks fine, but i'd like to hear the opinion of
>> Ying Huang as well.
>
>
> I had asked him to look at this before I posted and he had no
> objections. He may have an opinion on moving dmi scan into
> efi_init, though this can certainly be done later if and when
> needed.
No, i think your patch is fine as-is - moving the dmi scan to
EFI init just makes EFI bootstrap a bit less standard - hence a
bit more fragile - and that's never good.
Since your patch fixes real issues on Apple hardware i also
queued it up in tip:x86/urgent for .29-rc8.
Ingo
next prev parent reply other threads:[~2009-03-04 18:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-01 2:40 [PATCH] fix DMI for EFI Brian Maly
2009-03-01 2:56 ` Yinghai Lu
2009-03-01 3:11 ` Brian Maly
2009-03-01 3:25 ` Yinghai Lu
2009-03-01 3:58 ` Brian Maly
2009-03-04 2:55 ` Brian Maly
2009-03-04 11:00 ` Ingo Molnar
2009-03-04 15:03 ` Brian Maly
2009-03-04 17:54 ` Ingo Molnar
2009-03-04 18:00 ` Brian Maly
2009-03-04 18:02 ` Ingo Molnar [this message]
2009-03-05 1:33 ` Huang Ying
2009-03-05 10:05 ` Ingo Molnar
2009-03-04 17:57 ` [tip:x86/urgent] x86: fix DMI on EFI Brian Maly
-- strict thread matches above, loose matches on Subject: below --
2009-03-01 1:33 [PATCH] fix DMI for EFI Brian Maly
2009-03-01 2:01 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090304180255.GC1537@elte.hu \
--to=mingo@elte.hu \
--cc=bmaly@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ying.huang@intel.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox