* [PATCH 1/1] unifdef.c change "getline" to "get_line" to avoid C library confusion.
@ 2009-03-05 5:41 Justin Mattock
2009-03-05 6:04 ` Frederic Weisbecker
0 siblings, 1 reply; 10+ messages in thread
From: Justin Mattock @ 2009-03-05 5:41 UTC (permalink / raw)
To: Linux Kernel Mailing List
From: Justin P. Mattock <justinmattock@gmail.com>
This fixes an error when compiling the kernel.
CHK include/linux/version.h
HOSTCC scripts/unifdef
scripts/unifdef.c:209: error: conflicting types for 'getline'
/usr/include/stdio.h:651: note: previous declaration of 'getline' was here
make[1]: *** [scripts/unifdef] Error 1
make: *** [__headers] Error 2
--
scripts/unifdef.c | 3 +++
1 files changed, 3 insertions(+),0 deletions(-)
diff --git a/scripts/unifdef.c b/scripts/unifdef.c
---a/scripts/unifdef.c
+++b/scripts/unifdef.c
@@ -203,1 +203,0 @@ static void addsym(bool, bool, char *);
static void done(void);
static void error(const char *);
static int findsym(const char *);
static void flushline(bool);
-static Linetype getline(void);
+static Linetype get_line(void);
static Linetype ifeval(const char **);
static void ignoreoff(void);
static void ignoreon(void);
static void keywordedit(const char *);
@@ -509,1 +509,0 @@ process(void)
{
Linetype lineval;
for (;;) {
linenum++;
- lineval = getline();
+ lineval = get_line();
trans_table[ifstate[depth]][lineval]();
debug("process %s -> %s depth %d",
linetype_name[lineval],
ifstate_name[ifstate[depth]], depth);
}
}
@@ -528,1 +528,0 @@ static Linetype
-getline(void)
+get_line(void)
{
const char *cp;
--
keep in mind I've never created a patch before,
(so go easy on me);
regards;
--
Justin P. Mattock
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 1/1] unifdef.c change "getline" to "get_line" to avoid C library confusion. 2009-03-05 5:41 [PATCH 1/1] unifdef.c change "getline" to "get_line" to avoid C library confusion Justin Mattock @ 2009-03-05 6:04 ` Frederic Weisbecker 2009-03-05 7:51 ` Justin Mattock 0 siblings, 1 reply; 10+ messages in thread From: Frederic Weisbecker @ 2009-03-05 6:04 UTC (permalink / raw) To: Justin Mattock; +Cc: Linux Kernel Mailing List, Andrew Morton On Wed, Mar 04, 2009 at 09:41:09PM -0800, Justin Mattock wrote: > From: Justin P. Mattock <justinmattock@gmail.com> > > This fixes an error when compiling the kernel. > > CHK include/linux/version.h > HOSTCC scripts/unifdef > scripts/unifdef.c:209: error: conflicting types for 'getline' > /usr/include/stdio.h:651: note: previous declaration of 'getline' was here > make[1]: *** [scripts/unifdef] Error 1 > make: *** [__headers] Error 2 > > -- > scripts/unifdef.c | 3 +++ > 1 files changed, 3 insertions(+),0 deletions(-) > > diff --git a/scripts/unifdef.c b/scripts/unifdef.c > ---a/scripts/unifdef.c > +++b/scripts/unifdef.c > @@ -203,1 +203,0 @@ static void addsym(bool, bool, char *); > > > static void done(void); > static void error(const char *); > static int findsym(const char *); > static void flushline(bool); > -static Linetype getline(void); > +static Linetype get_line(void); > static Linetype ifeval(const char **); > static void ignoreoff(void); > static void ignoreon(void); > static void keywordedit(const char *); > > > > > @@ -509,1 +509,0 @@ process(void) > > > { > Linetype lineval; > > for (;;) { > linenum++; > - lineval = getline(); > + lineval = get_line(); > trans_table[ifstate[depth]][lineval](); > debug("process %s -> %s depth %d", > linetype_name[lineval], > ifstate_name[ifstate[depth]], depth); > } > } > > > @@ -528,1 +528,0 @@ static Linetype > -getline(void) > +get_line(void) > { > const char *cp; > > -- > > > keep in mind I've never created a patch before, > (so go easy on me); Hi, You forgot to put your Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> :) See Documentation/SubmittingPatches I don't know who is the maintainer of this file. Adding Andrew in Cc. > regards; > > -- > Justin P. Mattock > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] unifdef.c change "getline" to "get_line" to avoid C library confusion. 2009-03-05 6:04 ` Frederic Weisbecker @ 2009-03-05 7:51 ` Justin Mattock 2009-03-05 8:46 ` Justin Mattock 0 siblings, 1 reply; 10+ messages in thread From: Justin Mattock @ 2009-03-05 7:51 UTC (permalink / raw) To: Frederic Weisbecker; +Cc: Linux Kernel Mailing List, Andrew Morton On Wed, Mar 4, 2009 at 10:04 PM, Frederic Weisbecker <fweisbec@gmail.com> wrote: > On Wed, Mar 04, 2009 at 09:41:09PM -0800, Justin Mattock wrote: >> From: Justin P. Mattock <justinmattock@gmail.com> >> >> This fixes an error when compiling the kernel. >> >> CHK include/linux/version.h >> HOSTCC scripts/unifdef >> scripts/unifdef.c:209: error: conflicting types for 'getline' >> /usr/include/stdio.h:651: note: previous declaration of 'getline' was here >> make[1]: *** [scripts/unifdef] Error 1 >> make: *** [__headers] Error 2 >> >> -- >> scripts/unifdef.c | 3 +++ >> 1 files changed, 3 insertions(+),0 deletions(-) >> >> diff --git a/scripts/unifdef.c b/scripts/unifdef.c >> ---a/scripts/unifdef.c >> +++b/scripts/unifdef.c >> @@ -203,1 +203,0 @@ static void addsym(bool, bool, char *); >> >> >> static void done(void); >> static void error(const char *); >> static int findsym(const char *); >> static void flushline(bool); >> -static Linetype getline(void); >> +static Linetype get_line(void); >> static Linetype ifeval(const char **); >> static void ignoreoff(void); >> static void ignoreon(void); >> static void keywordedit(const char *); >> >> >> >> >> @@ -509,1 +509,0 @@ process(void) >> >> >> { >> Linetype lineval; >> >> for (;;) { >> linenum++; >> - lineval = getline(); >> + lineval = get_line(); >> trans_table[ifstate[depth]][lineval](); >> debug("process %s -> %s depth %d", >> linetype_name[lineval], >> ifstate_name[ifstate[depth]], depth); >> } >> } >> >> >> @@ -528,1 +528,0 @@ static Linetype >> -getline(void) >> +get_line(void) >> { >> const char *cp; >> >> -- >> >> >> keep in mind I've never created a patch before, >> (so go easy on me); > > > Hi, > > You forgot to put your Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> > :) > > See Documentation/SubmittingPatches > > I don't know who is the maintainer of this file. > Adding Andrew in Cc. > > >> regards; >> >> -- >> Justin P. Mattock >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ > > Cool, thanks for the help. I'll look at the doc's and google as much as possible, so I get this correct. regards; -- Justin P. Mattock ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] unifdef.c change "getline" to "get_line" to avoid C library confusion. 2009-03-05 7:51 ` Justin Mattock @ 2009-03-05 8:46 ` Justin Mattock 2009-03-05 8:49 ` Justin Mattock 2009-03-05 9:00 ` Frederic Weisbecker 0 siblings, 2 replies; 10+ messages in thread From: Justin Mattock @ 2009-03-05 8:46 UTC (permalink / raw) To: Frederic Weisbecker; +Cc: Linux Kernel Mailing List, Andrew Morton On Wed, Mar 4, 2009 at 11:51 PM, Justin Mattock <justinmattock@gmail.com> wrote: > On Wed, Mar 4, 2009 at 10:04 PM, Frederic Weisbecker <fweisbec@gmail.com> wrote: >> On Wed, Mar 04, 2009 at 09:41:09PM -0800, Justin Mattock wrote: >>> From: Justin P. Mattock <justinmattock@gmail.com> >>> >>> This fixes an error when compiling the kernel. >>> >>> CHK include/linux/version.h >>> HOSTCC scripts/unifdef >>> scripts/unifdef.c:209: error: conflicting types for 'getline' >>> /usr/include/stdio.h:651: note: previous declaration of 'getline' was here >>> make[1]: *** [scripts/unifdef] Error 1 >>> make: *** [__headers] Error 2 >>> >>> -- >>> scripts/unifdef.c | 3 +++ >>> 1 files changed, 3 insertions(+),0 deletions(-) >>> >>> diff --git a/scripts/unifdef.c b/scripts/unifdef.c >>> ---a/scripts/unifdef.c >>> +++b/scripts/unifdef.c >>> @@ -203,1 +203,0 @@ static void addsym(bool, bool, char *); >>> >>> >>> static void done(void); >>> static void error(const char *); >>> static int findsym(const char *); >>> static void flushline(bool); >>> -static Linetype getline(void); >>> +static Linetype get_line(void); >>> static Linetype ifeval(const char **); >>> static void ignoreoff(void); >>> static void ignoreon(void); >>> static void keywordedit(const char *); >>> >>> >>> >>> >>> @@ -509,1 +509,0 @@ process(void) >>> >>> >>> { >>> Linetype lineval; >>> >>> for (;;) { >>> linenum++; >>> - lineval = getline(); >>> + lineval = get_line(); >>> trans_table[ifstate[depth]][lineval](); >>> debug("process %s -> %s depth %d", >>> linetype_name[lineval], >>> ifstate_name[ifstate[depth]], depth); >>> } >>> } >>> >>> >>> @@ -528,1 +528,0 @@ static Linetype >>> -getline(void) >>> +get_line(void) >>> { >>> const char *cp; >>> >>> -- >>> >>> >>> keep in mind I've never created a patch before, >>> (so go easy on me); >> >> >> Hi, >> >> You forgot to put your Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> >> :) >> >> See Documentation/SubmittingPatches >> >> I don't know who is the maintainer of this file. >> Adding Andrew in Cc. >> >> >>> regards; >>> >>> -- >>> Justin P. Mattock >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> Please read the FAQ at http://www.tux.org/lkml/ >> >> > > Cool, > thanks for the help. > I'll look at the doc's and google > as much as possible, so I get this > correct. > > regards; > > -- > Justin P. Mattock > O.K. after doing some reading, I have a better idea of how to make a patch. I used diff, used patch -Np1, and compiled. and added the signed off part. I'll post after this post. and take any suggestions on what to do next. -- Justin P. Mattock ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] unifdef.c change "getline" to "get_line" to avoid C library confusion. 2009-03-05 8:46 ` Justin Mattock @ 2009-03-05 8:49 ` Justin Mattock 2009-03-05 8:57 ` Américo Wang 2009-03-05 15:33 ` Randy Dunlap 2009-03-05 9:00 ` Frederic Weisbecker 1 sibling, 2 replies; 10+ messages in thread From: Justin Mattock @ 2009-03-05 8:49 UTC (permalink / raw) To: Frederic Weisbecker; +Cc: Linux Kernel Mailing List, Andrew Morton On Thu, Mar 5, 2009 at 12:46 AM, Justin Mattock <justinmattock@gmail.com> wrote: > On Wed, Mar 4, 2009 at 11:51 PM, Justin Mattock <justinmattock@gmail.com> wrote: >> On Wed, Mar 4, 2009 at 10:04 PM, Frederic Weisbecker <fweisbec@gmail.com> wrote: >>> On Wed, Mar 04, 2009 at 09:41:09PM -0800, Justin Mattock wrote: >>>> From: Justin P. Mattock <justinmattock@gmail.com> >>>> >>>> This fixes an error when compiling the kernel. >>>> >>>> CHK include/linux/version.h >>>> HOSTCC scripts/unifdef >>>> scripts/unifdef.c:209: error: conflicting types for 'getline' >>>> /usr/include/stdio.h:651: note: previous declaration of 'getline' was here >>>> make[1]: *** [scripts/unifdef] Error 1 >>>> make: *** [__headers] Error 2 >>>> >>>> -- >>>> scripts/unifdef.c | 3 +++ >>>> 1 files changed, 3 insertions(+),0 deletions(-) >>>> >>>> diff --git a/scripts/unifdef.c b/scripts/unifdef.c >>>> ---a/scripts/unifdef.c >>>> +++b/scripts/unifdef.c >>>> @@ -203,1 +203,0 @@ static void addsym(bool, bool, char *); >>>> >>>> >>>> static void done(void); >>>> static void error(const char *); >>>> static int findsym(const char *); >>>> static void flushline(bool); >>>> -static Linetype getline(void); >>>> +static Linetype get_line(void); >>>> static Linetype ifeval(const char **); >>>> static void ignoreoff(void); >>>> static void ignoreon(void); >>>> static void keywordedit(const char *); >>>> >>>> >>>> >>>> >>>> @@ -509,1 +509,0 @@ process(void) >>>> >>>> >>>> { >>>> Linetype lineval; >>>> >>>> for (;;) { >>>> linenum++; >>>> - lineval = getline(); >>>> + lineval = get_line(); >>>> trans_table[ifstate[depth]][lineval](); >>>> debug("process %s -> %s depth %d", >>>> linetype_name[lineval], >>>> ifstate_name[ifstate[depth]], depth); >>>> } >>>> } >>>> >>>> >>>> @@ -528,1 +528,0 @@ static Linetype >>>> -getline(void) >>>> +get_line(void) >>>> { >>>> const char *cp; >>>> >>>> -- >>>> >>>> >>>> keep in mind I've never created a patch before, >>>> (so go easy on me); >>> >>> >>> Hi, >>> >>> You forgot to put your Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> >>> :) >>> >>> See Documentation/SubmittingPatches >>> >>> I don't know who is the maintainer of this file. >>> Adding Andrew in Cc. >>> >>> >>>> regards; >>>> >>>> -- >>>> Justin P. Mattock >>>> -- >>>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >>>> the body of a message to majordomo@vger.kernel.org >>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>>> Please read the FAQ at http://www.tux.org/lkml/ >>> >>> >> >> Cool, >> thanks for the help. >> I'll look at the doc's and google >> as much as possible, so I get this >> correct. >> >> regards; >> >> -- >> Justin P. Mattock >> > > O.K. after doing some reading, > I have a better idea of how to make a > patch. I used diff, used patch -Np1, and compiled. > and added the signed off part. > I'll post after this post. > and take any suggestions on what to do next. > > -- > Justin P. Mattock > From: Justin P. Mattock <justinmattock@gmail.com> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> This fixes an error when compiling the kernel. CHK include/linux/version.h HOSTCC scripts/unifdef scripts/unifdef.c:209: error: conflicting types for 'getline' /usr/include/stdio.h:651: note: previous declaration of 'getline' was here make[1]: *** [scripts/unifdef] Error 1 make: *** [__headers] Error 2 -- scripts/unifdef.c | 3 +++ 1 files changed, 3 insertions(+),0 deletions(-) ---a/scripts/unifdef.c 2009-03-05 00:07:28.000000000 -0800 +++b/scripts/unifdef.c 2009-03-05 00:04:56.000000000 -0800 @@ -206,7 +206,7 @@ static void done(void); static void error(const char *); static int findsym(const char *); static void flushline(bool); -static Linetype getline(void); +static Linetype get_line(void); static Linetype ifeval(const char **); static void ignoreoff(void); static void ignoreon(void); @@ -512,7 +512,7 @@ process(void) for (;;) { linenum++; - lineval = getline(); + lineval = get_line(); trans_table[ifstate[depth]][lineval](); debug("process %s -> %s depth %d", linetype_name[lineval], @@ -526,7 +526,7 @@ process(void) * help from skipcomment(). */ static Linetype -getline(void) +get_line(void) { const char *cp; int cursym; -- Justin P. Mattock ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] unifdef.c change "getline" to "get_line" to avoid C library confusion. 2009-03-05 8:49 ` Justin Mattock @ 2009-03-05 8:57 ` Américo Wang 2009-03-05 15:33 ` Randy Dunlap 1 sibling, 0 replies; 10+ messages in thread From: Américo Wang @ 2009-03-05 8:57 UTC (permalink / raw) To: Justin Mattock Cc: Frederic Weisbecker, Linux Kernel Mailing List, Andrew Morton, Sam Ravnborg On Thu, Mar 05, 2009 at 12:49:49AM -0800, Justin Mattock wrote: >From: Justin P. Mattock <justinmattock@gmail.com> >Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> > >This fixes an error when compiling the kernel. > > CHK include/linux/version.h > HOSTCC scripts/unifdef >scripts/unifdef.c:209: error: conflicting types for 'getline' >/usr/include/stdio.h:651: note: previous declaration of 'getline' was here >make[1]: *** [scripts/unifdef] Error 1 >make: *** [__headers] Error 2 > Looks good! Thanks. If you need, you can add my Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com> And let's Cc Sam: Cc: Sam Ravnborg <sam@ravnborg.org> >-- >scripts/unifdef.c | 3 +++ >1 files changed, 3 insertions(+),0 deletions(-) > >---a/scripts/unifdef.c 2009-03-05 00:07:28.000000000 -0800 >+++b/scripts/unifdef.c 2009-03-05 00:04:56.000000000 -0800 >@@ -206,7 +206,7 @@ static void done(void); > static void error(const char *); > static int findsym(const char *); > static void flushline(bool); >-static Linetype getline(void); >+static Linetype get_line(void); > static Linetype ifeval(const char **); > static void ignoreoff(void); > static void ignoreon(void); >@@ -512,7 +512,7 @@ process(void) > > for (;;) { > linenum++; >- lineval = getline(); >+ lineval = get_line(); > trans_table[ifstate[depth]][lineval](); > debug("process %s -> %s depth %d", > linetype_name[lineval], >@@ -526,7 +526,7 @@ process(void) > * help from skipcomment(). > */ > static Linetype >-getline(void) >+get_line(void) > { > const char *cp; > int cursym; > > >-- >Justin P. Mattock >-- >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html >Please read the FAQ at http://www.tux.org/lkml/ -- Do what you love, f**k the rest! F**k the regulations! ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] unifdef.c change "getline" to "get_line" to avoid C library confusion. 2009-03-05 8:49 ` Justin Mattock 2009-03-05 8:57 ` Américo Wang @ 2009-03-05 15:33 ` Randy Dunlap 2009-03-05 17:42 ` Justin Mattock 1 sibling, 1 reply; 10+ messages in thread From: Randy Dunlap @ 2009-03-05 15:33 UTC (permalink / raw) To: Justin Mattock Cc: Frederic Weisbecker, Linux Kernel Mailing List, Andrew Morton > From: Justin P. Mattock <justinmattock@gmail.com> > Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> > > This fixes an error when compiling the kernel. Did you determine why you need this now and other people don't need it (yet)? Maybe the rest of us will need it in the future... > CHK include/linux/version.h > HOSTCC scripts/unifdef > scripts/unifdef.c:209: error: conflicting types for 'getline' > /usr/include/stdio.h:651: note: previous declaration of 'getline' was here > make[1]: *** [scripts/unifdef] Error 1 > make: *** [__headers] Error 2 > > -- > scripts/unifdef.c | 3 +++ > 1 files changed, 3 insertions(+),0 deletions(-) > > ---a/scripts/unifdef.c 2009-03-05 00:07:28.000000000 -0800 > +++b/scripts/unifdef.c 2009-03-05 00:04:56.000000000 -0800 > @@ -206,7 +206,7 @@ static void done(void); > static void error(const char *); > static int findsym(const char *); > static void flushline(bool); > -static Linetype getline(void); > +static Linetype get_line(void); > static Linetype ifeval(const char **); > static void ignoreoff(void); > static void ignoreon(void); > @@ -512,7 +512,7 @@ process(void) > > for (;;) { > linenum++; > - lineval = getline(); > + lineval = get_line(); > trans_table[ifstate[depth]][lineval](); > debug("process %s -> %s depth %d", > linetype_name[lineval], > @@ -526,7 +526,7 @@ process(void) > * help from skipcomment(). > */ > static Linetype > -getline(void) > +get_line(void) > { > const char *cp; > int cursym; > > -- ~Randy ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] unifdef.c change "getline" to "get_line" to avoid C library confusion. 2009-03-05 15:33 ` Randy Dunlap @ 2009-03-05 17:42 ` Justin Mattock 0 siblings, 0 replies; 10+ messages in thread From: Justin Mattock @ 2009-03-05 17:42 UTC (permalink / raw) To: Randy Dunlap Cc: Frederic Weisbecker, Linux Kernel Mailing List, Andrew Morton, Mike Frysinger On Thu, Mar 5, 2009 at 7:33 AM, Randy Dunlap <randy.dunlap@oracle.com> wrote: >> From: Justin P. Mattock <justinmattock@gmail.com> >> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> >> >> This fixes an error when compiling the kernel. > > Did you determine why you need this now and other people don't > need it (yet)? Maybe the rest of us will need it in the future... > > >> CHK include/linux/version.h >> HOSTCC scripts/unifdef >> scripts/unifdef.c:209: error: conflicting types for 'getline' >> /usr/include/stdio.h:651: note: previous declaration of 'getline' was here >> make[1]: *** [scripts/unifdef] Error 1 >> make: *** [__headers] Error 2 >> >> -- >> scripts/unifdef.c | 3 +++ >> 1 files changed, 3 insertions(+),0 deletions(-) >> >> ---a/scripts/unifdef.c 2009-03-05 00:07:28.000000000 -0800 >> +++b/scripts/unifdef.c 2009-03-05 00:04:56.000000000 -0800 >> @@ -206,7 +206,7 @@ static void done(void); >> static void error(const char *); >> static int findsym(const char *); >> static void flushline(bool); >> -static Linetype getline(void); >> +static Linetype get_line(void); >> static Linetype ifeval(const char **); >> static void ignoreoff(void); >> static void ignoreon(void); >> @@ -512,7 +512,7 @@ process(void) >> >> for (;;) { >> linenum++; >> - lineval = getline(); >> + lineval = get_line(); >> trans_table[ifstate[depth]][lineval](); >> debug("process %s -> %s depth %d", >> linetype_name[lineval], >> @@ -526,7 +526,7 @@ process(void) >> * help from skipcomment(). >> */ >> static Linetype >> -getline(void) >> +get_line(void) >> { >> const char *cp; >> int cursym; >> >> > > > -- > ~Randy > As for why I need this: I keep getting an error while compiling the latest kernel. (changing getline to get_line fixes it from here); As for others needing this: probably in the category for future use. especially if people don't upgrade there kernel and libc. In speculation though, people may never hit this. The setup I did was created an LFS system(always wanted to create a linux system from source). While creating this starting with a plain directory, then compiling make, gcc, libc, making sure to set CFLAGS, (in accordance to the processor) then after those were complete, set the same CFLAGS for every lib/app that I compiled and put into the system. (this way the system is atomically synchronized with the processor); Thus changing the whole setup that I have. But then If this was the case I would of hit this probably earlier with 2.6.29-rc4/5. In regards to the patch(to make things correct) what or how do I label this person in the patch so they get the proper credit: vapier@gentoo.org They were responsible with providing the change of getline to get_line. should it be: Critical-info-by: Mike Frysinger <vapier@gentoo.org> And also adding the people who reviewed the patch. This way the patch is proper irregardless of the patch making it or not. regards; -- Justin P. Mattock ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] unifdef.c change "getline" to "get_line" to avoid C library confusion. 2009-03-05 8:46 ` Justin Mattock 2009-03-05 8:49 ` Justin Mattock @ 2009-03-05 9:00 ` Frederic Weisbecker 2009-03-05 14:48 ` Justin Mattock 1 sibling, 1 reply; 10+ messages in thread From: Frederic Weisbecker @ 2009-03-05 9:00 UTC (permalink / raw) To: Justin Mattock; +Cc: Linux Kernel Mailing List, Andrew Morton On Thu, Mar 05, 2009 at 12:46:16AM -0800, Justin Mattock wrote: > On Wed, Mar 4, 2009 at 11:51 PM, Justin Mattock <justinmattock@gmail.com> wrote: > > On Wed, Mar 4, 2009 at 10:04 PM, Frederic Weisbecker <fweisbec@gmail.com> wrote: > >> On Wed, Mar 04, 2009 at 09:41:09PM -0800, Justin Mattock wrote: > >>> From: Justin P. Mattock <justinmattock@gmail.com> > >>> > >>> This fixes an error when compiling the kernel. > >>> > >>> CHK include/linux/version.h > >>> HOSTCC scripts/unifdef > >>> scripts/unifdef.c:209: error: conflicting types for 'getline' > >>> /usr/include/stdio.h:651: note: previous declaration of 'getline' was here > >>> make[1]: *** [scripts/unifdef] Error 1 > >>> make: *** [__headers] Error 2 > >>> > >>> -- > >>> scripts/unifdef.c | 3 +++ > >>> 1 files changed, 3 insertions(+),0 deletions(-) > >>> > >>> diff --git a/scripts/unifdef.c b/scripts/unifdef.c > >>> ---a/scripts/unifdef.c > >>> +++b/scripts/unifdef.c > >>> @@ -203,1 +203,0 @@ static void addsym(bool, bool, char *); > >>> > >>> > >>> static void done(void); > >>> static void error(const char *); > >>> static int findsym(const char *); > >>> static void flushline(bool); > >>> -static Linetype getline(void); > >>> +static Linetype get_line(void); > >>> static Linetype ifeval(const char **); > >>> static void ignoreoff(void); > >>> static void ignoreon(void); > >>> static void keywordedit(const char *); > >>> > >>> > >>> > >>> > >>> @@ -509,1 +509,0 @@ process(void) > >>> > >>> > >>> { > >>> Linetype lineval; > >>> > >>> for (;;) { > >>> linenum++; > >>> - lineval = getline(); > >>> + lineval = get_line(); > >>> trans_table[ifstate[depth]][lineval](); > >>> debug("process %s -> %s depth %d", > >>> linetype_name[lineval], > >>> ifstate_name[ifstate[depth]], depth); > >>> } > >>> } > >>> > >>> > >>> @@ -528,1 +528,0 @@ static Linetype > >>> -getline(void) > >>> +get_line(void) > >>> { > >>> const char *cp; > >>> > >>> -- > >>> > >>> > >>> keep in mind I've never created a patch before, > >>> (so go easy on me); > >> > >> > >> Hi, > >> > >> You forgot to put your Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> > >> :) > >> > >> See Documentation/SubmittingPatches > >> > >> I don't know who is the maintainer of this file. > >> Adding Andrew in Cc. > >> > >> > >>> regards; > >>> > >>> -- > >>> Justin P. Mattock > >>> -- > >>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > >>> the body of a message to majordomo@vger.kernel.org > >>> More majordomo info at http://vger.kernel.org/majordomo-info.html > >>> Please read the FAQ at http://www.tux.org/lkml/ > >> > >> > > > > Cool, > > thanks for the help. > > I'll look at the doc's and google > > as much as possible, so I get this > > correct. > > > > regards; > > > > -- > > Justin P. Mattock > > > > O.K. after doing some reading, > I have a better idea of how to make a > patch. I used diff, used patch -Np1, and compiled. > and added the signed off part. > I'll post after this post. > and take any suggestions on what to do next. > > -- > Justin P. Mattock I note that you used git right? One thing that you can do is to use git-format-patch which does the most part of it: Create a local branch based on which you are working on: git-checkout -b mybranch //modify what you want //And commit the changes: git-commit -a Once it is done, you can generate your patch by typing: git-format-patch -p -s -1 But, all of these steps are mostly useful if you are working on a whole patchset, usually for a single patch, just type git-diff > my_patch.diff And add your Signed-off-by The usual diff tool is useful when you are doing a patch on a non-git tree. If you are on a git tree, git-diff is really easier. And also important: always find the right persons to Cc when you send a patch. It's easy for anyone to miss it on the whole noise. Try to find these persons on the MAINTAINERS file, or by using git-log to find those who recently committed the patches in this area, or if you don't find anyone, then Cc Andrew Morton, he will route it to the appropriate maintainers. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] unifdef.c change "getline" to "get_line" to avoid C library confusion. 2009-03-05 9:00 ` Frederic Weisbecker @ 2009-03-05 14:48 ` Justin Mattock 0 siblings, 0 replies; 10+ messages in thread From: Justin Mattock @ 2009-03-05 14:48 UTC (permalink / raw) To: Frederic Weisbecker; +Cc: Linux Kernel Mailing List, Andrew Morton On Thu, Mar 5, 2009 at 1:00 AM, Frederic Weisbecker <fweisbec@gmail.com> wrote: > On Thu, Mar 05, 2009 at 12:46:16AM -0800, Justin Mattock wrote: >> On Wed, Mar 4, 2009 at 11:51 PM, Justin Mattock <justinmattock@gmail.com> wrote: >> > On Wed, Mar 4, 2009 at 10:04 PM, Frederic Weisbecker <fweisbec@gmail.com> wrote: >> >> On Wed, Mar 04, 2009 at 09:41:09PM -0800, Justin Mattock wrote: >> >>> From: Justin P. Mattock <justinmattock@gmail.com> >> >>> >> >>> This fixes an error when compiling the kernel. >> >>> >> >>> CHK include/linux/version.h >> >>> HOSTCC scripts/unifdef >> >>> scripts/unifdef.c:209: error: conflicting types for 'getline' >> >>> /usr/include/stdio.h:651: note: previous declaration of 'getline' was here >> >>> make[1]: *** [scripts/unifdef] Error 1 >> >>> make: *** [__headers] Error 2 >> >>> >> >>> -- >> >>> scripts/unifdef.c | 3 +++ >> >>> 1 files changed, 3 insertions(+),0 deletions(-) >> >>> >> >>> diff --git a/scripts/unifdef.c b/scripts/unifdef.c >> >>> ---a/scripts/unifdef.c >> >>> +++b/scripts/unifdef.c >> >>> @@ -203,1 +203,0 @@ static void addsym(bool, bool, char *); >> >>> >> >>> >> >>> static void done(void); >> >>> static void error(const char *); >> >>> static int findsym(const char *); >> >>> static void flushline(bool); >> >>> -static Linetype getline(void); >> >>> +static Linetype get_line(void); >> >>> static Linetype ifeval(const char **); >> >>> static void ignoreoff(void); >> >>> static void ignoreon(void); >> >>> static void keywordedit(const char *); >> >>> >> >>> >> >>> >> >>> >> >>> @@ -509,1 +509,0 @@ process(void) >> >>> >> >>> >> >>> { >> >>> Linetype lineval; >> >>> >> >>> for (;;) { >> >>> linenum++; >> >>> - lineval = getline(); >> >>> + lineval = get_line(); >> >>> trans_table[ifstate[depth]][lineval](); >> >>> debug("process %s -> %s depth %d", >> >>> linetype_name[lineval], >> >>> ifstate_name[ifstate[depth]], depth); >> >>> } >> >>> } >> >>> >> >>> >> >>> @@ -528,1 +528,0 @@ static Linetype >> >>> -getline(void) >> >>> +get_line(void) >> >>> { >> >>> const char *cp; >> >>> >> >>> -- >> >>> >> >>> >> >>> keep in mind I've never created a patch before, >> >>> (so go easy on me); >> >> >> >> >> >> Hi, >> >> >> >> You forgot to put your Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> >> >> :) >> >> >> >> See Documentation/SubmittingPatches >> >> >> >> I don't know who is the maintainer of this file. >> >> Adding Andrew in Cc. >> >> >> >> >> >>> regards; >> >>> >> >>> -- >> >>> Justin P. Mattock >> >>> -- >> >>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> >>> the body of a message to majordomo@vger.kernel.org >> >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >>> Please read the FAQ at http://www.tux.org/lkml/ >> >> >> >> >> > >> > Cool, >> > thanks for the help. >> > I'll look at the doc's and google >> > as much as possible, so I get this >> > correct. >> > >> > regards; >> > >> > -- >> > Justin P. Mattock >> > >> >> O.K. after doing some reading, >> I have a better idea of how to make a >> patch. I used diff, used patch -Np1, and compiled. >> and added the signed off part. >> I'll post after this post. >> and take any suggestions on what to do next. >> >> -- >> Justin P. Mattock > > > I note that you used git right? > One thing that you can do is to use git-format-patch which does the most > part of it: > > Create a local branch based on which you are working on: > > git-checkout -b mybranch > //modify what you want > //And commit the changes: > > git-commit -a > > Once it is done, you can generate your patch by typing: > > git-format-patch -p -s -1 > > But, all of these steps are mostly useful if you are working on a whole patchset, > usually for a single patch, just type git-diff > my_patch.diff > And add your Signed-off-by > > The usual diff tool is useful when you are doing a patch on a non-git tree. > If you are on a git tree, git-diff is really easier. > > And also important: always find the right persons to Cc when > you send a patch. It's easy for anyone to miss it on the whole noise. > > Try to find these persons on the MAINTAINERS file, or by using git-log to find > those who recently committed the patches in this area, or if you don't find anyone, > then Cc Andrew Morton, he will route it to the appropriate maintainers. > > Cool, thanks for those pointers. As for the first patch(admittedl I look at another patch as an example of how it should look.) I googled a bit, but didn't see much. Then I figured I guess these guys manually just create these things. (which isn't the case). All was fine until the @@ +number -number @@ thread (part) Which confused me a bit. But then later on finding info on diff, and now you're pointers with git(opens a whole new world); I still need to do more reading up on this, So I can be prepared in the future if this ever occurs again. As for the patch itself. If need be I can resend with the signed off part in the correct location, as well as everybody involved with this. this way things are legit. -- Justin P. Mattock ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2009-03-05 17:43 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-03-05 5:41 [PATCH 1/1] unifdef.c change "getline" to "get_line" to avoid C library confusion Justin Mattock 2009-03-05 6:04 ` Frederic Weisbecker 2009-03-05 7:51 ` Justin Mattock 2009-03-05 8:46 ` Justin Mattock 2009-03-05 8:49 ` Justin Mattock 2009-03-05 8:57 ` Américo Wang 2009-03-05 15:33 ` Randy Dunlap 2009-03-05 17:42 ` Justin Mattock 2009-03-05 9:00 ` Frederic Weisbecker 2009-03-05 14:48 ` Justin Mattock
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox