Re: [PATCH 1/1] unifdef.c change "getline" to "get_line" to avoid C library confusion.

Frederic Weisbecker
2009-03-05T06:04:52Z

On Wed, Mar 04, 2009 at 09:41:09PM -0800, Justin Mattock wrote:
> From: Justin P. Mattock <justinmattock@gmail.com>
>
> This fixes an error when compiling the kernel.
>
> CHK include/linux/version.h
> HOSTCC scripts/unifdef
> scripts/unifdef.c:209: error: conflicting types for 'getline'
> /usr/include/stdio.h:651: note: previous declaration of 'getline' was here
> make[1]: *** [scripts/unifdef] Error 1
> make: *** [__headers] Error 2
>
> --
> scripts/unifdef.c | 3 +++
> 1 files changed, 3 insertions(+),0 deletions(-)
>
> diff --git a/scripts/unifdef.c b/scripts/unifdef.c
> ---a/scripts/unifdef.c
> +++b/scripts/unifdef.c
> @@ -203,1 +203,0 @@ static void addsym(bool, bool, char *);
>
>
> static void done(void);
> static void error(const char *);
> static int findsym(const char *);
> static void flushline(bool);
> -static Linetype getline(void);
> +static Linetype get_line(void);
> static Linetype ifeval(const char **);
> static void ignoreoff(void);
> static void ignoreon(void);
> static void keywordedit(const char *);
>
>
>
>
> @@ -509,1 +509,0 @@ process(void)
>
>
> {
> Linetype lineval;
>
> for (;;) {
> linenum++;
> - lineval = getline();
> + lineval = get_line();
> trans_table[ifstate[depth]][lineval]();
> debug("process %s -> %s depth %d",
> linetype_name[lineval],
> ifstate_name[ifstate[depth]], depth);
> }
> }
>
>
> @@ -528,1 +528,0 @@ static Linetype
> -getline(void)
> +get_line(void)
> {
> const char *cp;
>
> --
>
>
> keep in mind I've never created a patch before,
> (so go easy on me);

Hi,

You forgot to put your Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
:)

See Documentation/SubmittingPatches

I don't know who is the maintainer of this file.
Adding Andrew in Cc.

> regards;
>
> --
> Justin P. Mattock
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/