Re: [PATCH 1/1] unifdef.c change "getline" to "get_line" to avoid C library confusion.

Américo Wang
2009-03-05T08:57:43Z

On Thu, Mar 05, 2009 at 12:49:49AM -0800, Justin Mattock wrote:
>From: Justin P. Mattock <justinmattock@gmail.com>
>Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
>
>This fixes an error when compiling the kernel.
>
> CHK include/linux/version.h
> HOSTCC scripts/unifdef
>scripts/unifdef.c:209: error: conflicting types for 'getline'
>/usr/include/stdio.h:651: note: previous declaration of 'getline' was here
>make[1]: *** [scripts/unifdef] Error 1
>make: *** [__headers] Error 2
>

Looks good! Thanks. If you need, you can add my

Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>

And let's Cc Sam:

Cc: Sam Ravnborg <sam@ravnborg.org>

>--
>scripts/unifdef.c | 3 +++
>1 files changed, 3 insertions(+),0 deletions(-)
>
>---a/scripts/unifdef.c 2009-03-05 00:07:28.000000000 -0800
>+++b/scripts/unifdef.c 2009-03-05 00:04:56.000000000 -0800
>@@ -206,7 +206,7 @@ static void done(void);
> static void error(const char *);
> static int findsym(const char *);
> static void flushline(bool);
>-static Linetype getline(void);
>+static Linetype get_line(void);
> static Linetype ifeval(const char **);
> static void ignoreoff(void);
> static void ignoreon(void);
>@@ -512,7 +512,7 @@ process(void)
>
> for (;;) {
> linenum++;
>- lineval = getline();
>+ lineval = get_line();
> trans_table[ifstate[depth]][lineval]();
> debug("process %s -> %s depth %d",
> linetype_name[lineval],
>@@ -526,7 +526,7 @@ process(void)
> * help from skipcomment().
> */
> static Linetype
>-getline(void)
>+get_line(void)
> {
> const char *cp;
> int cursym;
>
>
>--
>Justin P. Mattock
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/

--
Do what you love, f**k the rest! F**k the regulations!