From: Ingo Molnar <mingo@elte.hu>
To: Dimitri Sivanich <sivanich@sgi.com>
Cc: linux-kernel@vger.kernel.org, the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [PATCH 4/3 v7] SGI RTC: fix uv_time for UP
Date: Thu, 5 Mar 2009 11:26:51 +0100 [thread overview]
Message-ID: <20090305102651.GA32407@elte.hu> (raw)
In-Reply-To: <20090304220246.GC6288@sgi.com>
* Dimitri Sivanich <sivanich@sgi.com> wrote:
> Fix non-smp build of uv_time.c.
>
> Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
>
> ---
>
> This time against tip/x86/uv
>
> arch/x86/kernel/uv_time.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> Index: linux-2.6.tip-uv/arch/x86/kernel/uv_time.c
> ===================================================================
> --- linux-2.6.tip-uv.orig/arch/x86/kernel/uv_time.c 2009-03-04 15:52:10.000000000 -0600
> +++ linux-2.6.tip-uv/arch/x86/kernel/uv_time.c 2009-03-04 15:58:48.000000000 -0600
> @@ -20,6 +20,9 @@
> */
> #include <linux/clockchips.h>
>
> +#include <asm/apic.h>
> +#include <asm/cpu.h>
> +
> #include <asm/uv/uv_mmrs.h>
> #include <asm/uv/uv_hub.h>
> #include <asm/uv/bios.h>
Btw: trivia: have you ever thought about why the include files
sections looks like that and why i modified your original patch?
Have a look at arch/x86/mm/fault.c.
Anyway, i fixed up your patch.
Ingo
next prev parent reply other threads:[~2009-03-05 10:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 18:54 [PATCH 0/3 v7] SGI RTC: add UV RTC clocksource/clockevents and generic system vector Dimitri Sivanich
2009-03-04 18:56 ` [PATCH 1/3 v7] SGI RTC: add " Dimitri Sivanich
2009-03-04 18:57 ` [PATCH 2/3 v7] SGI RTC: loop through installed UV blades Dimitri Sivanich
2009-03-04 18:59 ` [PATCH 3/3 v7] SGI RTC: add UV RTC clocksource/clockevents Dimitri Sivanich
2009-03-04 19:48 ` [tip:x86/uv] x86: UV, " Dimitri Sivanich
2009-03-04 19:48 ` [tip:x86/uv] x86: UV, SGI RTC: loop through installed UV blades Dimitri Sivanich
2009-03-04 19:48 ` [tip:x86/uv] x86: UV, SGI RTC: add generic system vector Dimitri Sivanich
2009-03-05 14:18 ` [tip:x86/uv] x86: UV, SGI RTC: add generic system vector, build fix on UP Ingo Molnar
2009-03-04 19:46 ` [PATCH 0/3 v7] SGI RTC: add UV RTC clocksource/clockevents and generic system vector Ingo Molnar
2009-03-04 20:45 ` [PATCH 4/3 v7] SGI RTC: fix uv_time for UP Dimitri Sivanich
2009-03-04 20:58 ` Ingo Molnar
2009-03-04 22:02 ` Dimitri Sivanich
2009-03-05 10:26 ` Ingo Molnar [this message]
2009-03-05 10:30 ` [tip:x86/uv] x86: UV, SGI RTC: fix uv_time.c " Dimitri Sivanich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090305102651.GA32407@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=sivanich@sgi.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox