Re: [PATCH 3/3] ide-{cd,floppy}: do not map all cmds to an sg

Borislav Petkov
2009-03-05T15:20:19Z

Hi,

> Unrelated to the original issue that the patch tries to fix
> (sg mapping no data commands which OOPS-es w/ DEBUG_VIRTUAL=y):
> - moving ide_init_sg_cmd()+ide_map_sg() to ide_issue_pc()
> - converting the code to use blk_rq_bytes()

aah, ok, now I could get exactly what you meant :). However, (!) ide-floppy is
potentially broken in the same way for data-less cmds since we unconditionally
map an rq to an sg there _too_. That was the reason for the other changes. And
yes, I should've been more clear in the changelog.

> [ Moreover if you actually cared to write down the proper changelog
>  I'm pretty sure that you would ask yourself whether these changes
>  really belong to a bugfix patch... ]

--
Regards/Gruss,
Boris