public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH -tip] sched: use need_resched
Date: Fri, 6 Mar 2009 11:49:25 +0100	[thread overview]
Message-ID: <20090306104925.GA21168@elte.hu> (raw)
In-Reply-To: <49B0F9C2.8060200@cn.fujitsu.com>


* Lai Jiangshan <laijs@cn.fujitsu.com> wrote:

> 
> Impact: cleanup
> 
> use need_resched() instead of unlikely(test_thread_flag(TIF_NEED_RESCHED))
> 
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>

looks good - but it does not apply cleanly to the latest 
scheduler tree:

   http://people.redhat.com/mingo/tip.git/README

Could you please send a merged up patch and also make sure 
there's no other TIF_NEED_RESCHED usage in kernel/sched.c that 
could be converted to need_resched()?

Thanks,

	Ingo

  reply	other threads:[~2009-03-06 10:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-06 10:24 [PATCH -tip] sched: use need_resched Lai Jiangshan
2009-03-06 10:49 ` Ingo Molnar [this message]
2009-03-06 11:40   ` [PATCH -tip] sched: cleanup for TIF_NEED_RESCHED Lai Jiangshan
2009-03-06 11:51     ` [tip:sched/cleanups] sched: TIF_NEED_RESCHED -> need_reshed() cleanup Lai Jiangshan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090306104925.GA21168@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox