From: Andrew Morton <akpm@linux-foundation.org>
To: Bryan Wu <cooloney@kernel.org>
Cc: alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org,
sonic.zhang@analog.com, cooloney@kernel.org
Subject: Re: [PATCH 17/18] Blackfin Serial Driver: Fix bug - Enable hardware based CTS and RTS for bf548.
Date: Fri, 6 Mar 2009 14:38:31 -0800 [thread overview]
Message-ID: <20090306143831.2b8c6c83.akpm@linux-foundation.org> (raw)
In-Reply-To: <1236321780-28718-18-git-send-email-cooloney@kernel.org>
On Fri, 6 Mar 2009 14:42:59 +0800
Bryan Wu <cooloney@kernel.org> wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> Both software emulated and hardware based CTS and RTS are enabled in
> serial driver.
>
> The CTS RTS PIN connection on BF548 UART port is defined as a modem
> device not as a host device. In order to test it under Linux, please
> nake a cross UART cable to exchange CTS and RTS signal.
>
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>
> ---
> .../mach-bf518/include/mach/bfin_serial_5xx.h | 10 +-
> .../mach-bf527/include/mach/bfin_serial_5xx.h | 10 +-
> .../mach-bf533/include/mach/bfin_serial_5xx.h | 9 +-
> .../mach-bf537/include/mach/bfin_serial_5xx.h | 10 +-
> .../mach-bf538/include/mach/bfin_serial_5xx.h | 10 +-
> .../mach-bf548/include/mach/bfin_serial_5xx.h | 72 ++++-----
> .../mach-bf561/include/mach/bfin_serial_5xx.h | 9 +-
> drivers/serial/Kconfig | 26 +++-
> drivers/serial/bfin_5xx.c | 169 ++++++++++++++------
> 9 files changed, 209 insertions(+), 116 deletions(-)
This is a huge patch for us to be merging into -rc7.
> --- a/arch/blackfin/mach-bf533/include/mach/bfin_serial_5xx.h
> +++ b/arch/blackfin/mach-bf533/include/mach/bfin_serial_5xx.h
> @@ -53,9 +53,9 @@
> #define UART_SET_DLAB(uart) do { UART_PUT_LCR(uart, UART_GET_LCR(uart) | DLAB); SSYNC(); } while (0)
> #define UART_CLEAR_DLAB(uart) do { UART_PUT_LCR(uart, UART_GET_LCR(uart) & ~DLAB); SSYNC(); } while (0)
>
> -#define UART_GET_CTS(x) gpio_get_value(x->cts_pin)
> -#define UART_SET_RTS(x) gpio_set_value(x->rts_pin, 1)
> -#define UART_CLEAR_RTS(x) gpio_set_value(x->rts_pin, 0)
> +#define UART_GET_CTS(x) (!gpio_get_value(x->cts_pin))
> +#define UART_DISABLE_RTS(x) gpio_set_value(x->rts_pin, 1)
> +#define UART_ENABLE_RTS(x) gpio_set_value(x->rts_pin, 0)
> #define UART_ENABLE_INTS(x, v) UART_PUT_IER(x, v)
> #define UART_DISABLE_INTS(x) UART_PUT_IER(x, 0)
>
> @@ -74,6 +74,7 @@
> struct bfin_serial_port {
> struct uart_port port;
> unsigned int old_status;
> + int status_irq;
> unsigned int lsr;
whitepace bustage in here.
next prev parent reply other threads:[~2009-03-06 22:40 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 6:42 [PATCH 00/18] Blackfin Serial Driver bug fixing and update Bryan Wu
2009-03-06 6:42 ` [PATCH 01/18] Blackfin Serial Driver: Add a debug function to serial driver Bryan Wu
2009-03-06 22:37 ` Andrew Morton
2009-03-06 6:42 ` [PATCH 02/18] Blackfin Serial Driver: use barrier instead of cpu_relax for Blackfin SMP like patch Bryan Wu
2009-03-06 22:37 ` Andrew Morton
2009-03-10 10:07 ` gyang
2009-03-10 10:25 ` Mike Frysinger
2009-03-10 16:48 ` Andrew Morton
2009-03-11 9:50 ` graff yang
2009-03-11 16:48 ` Andrew Morton
2009-03-06 6:42 ` [PATCH 03/18] Blackfin Serial Driver: fix a in dma circle rx buffer handling Bryan Wu
2009-03-06 22:38 ` Andrew Morton
2009-03-06 6:42 ` [PATCH 04/18] Blackfin Serial Driver: Change hardware flowcontrol from poll to interrupt driven Bryan Wu
2009-03-06 22:38 ` Andrew Morton
2009-03-06 22:49 ` Mike Frysinger
2009-03-06 23:00 ` Andrew Morton
2009-03-06 6:42 ` [PATCH 05/18] Blackfin Serial Driver: fix bug - serial port transfer big file from host to target would have more lines Bryan Wu
2009-03-06 22:38 ` Andrew Morton
2009-03-06 6:42 ` [PATCH 06/18] Blackfin Serial Driver: explain why we cannot cpu_relax() in early serial code Bryan Wu
2009-03-06 22:38 ` Andrew Morton
2009-03-06 6:42 ` [PATCH 07/18] Blackfin Serial Driver: BF538/9 Linux kernel Support Bryan Wu
2009-03-06 6:42 ` [PATCH 08/18] Blackfin Serial Driver: use "unsigned long" for flags with irq functions rather than "int" Bryan Wu
2009-03-06 6:42 ` [PATCH 09/18] Blackfin Serial Driver: irq funcs take an unsigned long for flags Bryan Wu
2009-03-06 6:42 ` [PATCH 10/18] Blackfin Serial Driver: fix compile error in PIO mode Bryan Wu
2009-03-06 6:42 ` [PATCH 11/18] Blackfin Serial Driver: update KGDB UART config name Bryan Wu
2009-03-06 6:42 ` [PATCH 12/18] Blackfin Serial Driver: fix building when debug is enabled but serial console is disabled Bryan Wu
2009-03-06 6:42 ` [PATCH 13/18] Blackfin Serial Driver: depend on KGDB_SERIAL_CONSOLE being set to N Bryan Wu
2009-03-06 6:42 ` [PATCH 14/18] Blackfin Serial Driver: use the DLAB macro to hide variant differences Bryan Wu
2009-03-06 22:38 ` Andrew Morton
2009-03-06 22:41 ` Mike Frysinger
2009-03-06 6:42 ` [PATCH 15/18] Blackfin Serial Driver: merge the upstream adeos/xenomai Bryan Wu
2009-03-06 22:38 ` Andrew Morton
2009-03-06 22:43 ` Mike Frysinger
2009-03-06 6:42 ` [PATCH 16/18] Blackfin Serial Driver: fix bug - up arrow key works abnormal for bf561 ezkit board Bryan Wu
2009-03-06 6:42 ` [PATCH 17/18] Blackfin Serial Driver: Fix bug - Enable hardware based CTS and RTS for bf548 Bryan Wu
2009-03-06 22:38 ` Andrew Morton [this message]
2009-03-06 6:43 ` [PATCH 18/18] Blackfin Serial Driver: update path to gpio header Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090306143831.2b8c6c83.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=cooloney@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sonic.zhang@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox