From: Rob Landley <rob@landley.net>
To: Jeff Dike <jdike@addtoit.com>
Cc: "Am??rico Wang" <xiyou.wangcong@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
user-mode-linux-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix ARCH=um segfault on x86-64.
Date: Fri, 6 Mar 2009 16:22:21 -0600 [thread overview]
Message-ID: <200903061622.22289.rob@landley.net> (raw)
In-Reply-To: <20090306143543.GA6983@c2.user-mode-linux.org>
On Friday 06 March 2009 08:35:43 Jeff Dike wrote:
> On Fri, Mar 06, 2009 at 07:18:34PM +0800, Am??rico Wang wrote:
> > It does work well x86_64, but my question is that whether this will
> > break i386 or not, since before, CONFIG_3_LEVEL_PGTABLES depends on
> > EXPERIMENTAL on i386, this patch removes it.
>
> As long as CONFIG_3_LEVEL_PGTABLES is off on 32-bit, it should be fine.
>
> It did work, last I checked, but 3-level page tables on 32-bit is a
> very rarely used combination, and not useful.
I have no idea if my patch is the _right_ fix, I just know I couldn't use UML
for 2 months and now I can.
If you enable CONFIG_EXPERIMENTAL, then it writes it out to the config file.
If you don't, it hides it and doesn't write it out even though the value would
be y. (The visibility predicates affect the resulting data.)
Rob
next prev parent reply other threads:[~2009-03-06 22:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 6:42 [PATCH] Fix ARCH=um segfault on x86-64 Rob Landley
2009-03-06 8:48 ` Américo Wang
2009-03-06 9:50 ` Geert Uytterhoeven
2009-03-06 9:51 ` Geert Uytterhoeven
2009-03-06 11:18 ` Américo Wang
2009-03-06 14:35 ` Jeff Dike
2009-03-06 22:22 ` Rob Landley [this message]
2009-03-10 14:29 ` Américo Wang
2009-03-06 22:20 ` Rob Landley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903061622.22289.rob@landley.net \
--to=rob@landley.net \
--cc=geert@linux-m68k.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox