From: Jarod Wilson <jarod@redhat.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: davej@redhat.com, cpufreq@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: Remove KERN_ERR output if nForce2 chipset not found
Date: Fri, 6 Mar 2009 17:01:03 -0500 [thread overview]
Message-ID: <200903061701.04348.jarod@redhat.com> (raw)
In-Reply-To: <adaljrigw0a.fsf@cisco.com>
On Friday 06 March 2009 16:51:49 Roland Dreier wrote:
> > Nb: Matthew Garrett submitted a similar-but-different patch a week or
> > two ago on the cpufreq list that demoted the message to KERN_INFO.
>
> Sorry, missed that. I considered the demotion to KERN_INFO but a) no
> other cpufreq drivers seem to print anything if the device isn't found
> and b) I can't imagine a realistic case of when the message would *ever*
> be useful.
Good points. I wasn't favoring one or the other 'til now, but simply
returning -ENODEV does indeed seem to be more in line with what other
freq scaling drivers do.
--
Jarod Wilson
jarod@redhat.com
prev parent reply other threads:[~2009-03-06 22:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 20:55 [PATCH] cpufreq: Remove KERN_ERR output if nForce2 chipset not found Roland Dreier
2009-03-06 21:06 ` Jarod Wilson
2009-03-06 21:51 ` Roland Dreier
2009-03-06 22:01 ` Jarod Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903061701.04348.jarod@redhat.com \
--to=jarod@redhat.com \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox