From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 4/5 v3] tracing/core: drop the old ftrace_printk implementation in favour of ftrace_bprintk
Date: Fri, 6 Mar 2009 19:49:04 +0100 [thread overview]
Message-ID: <20090306184904.GA24571@elte.hu> (raw)
In-Reply-To: <alpine.DEB.2.00.0903061302210.23248@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Fri, 6 Mar 2009, Ingo Molnar wrote:
> > >
> > > i've put them into a separate branch forked off
> > > tip:tracing/ftrace: tip:tracing/printk. The two vsprintf
> > > patches are in tip:core/printk and merged into tracing/ftrace.
> > >
> > > You can thus apply your current enhancements without any
> > > interaction with me - and merge tracing/printk into the
> > > tip:tracing/ftrace branch on your own schedule, ok?
> >
> > ah - i misunderstood - i see that it interacts with your commits
> > from last night.
> >
> > I've excluded tip:tracing/printk from tip:master for now and
> > will let you guys fix it up when you have time for it.
>
> Ingo,
>
> It compiles fine. Only a new item in the struct was added, nothing was
> removed. It just prints out a bit funny ;-)
>
> You can go ahead and merge it into tracing/ftrace, and then I
> can work with that to fix up the formatting.
triggers this build failure on certain configs:
kernel/trace/trace.c:1205: error: implicit declaration of function 'vbin_printf'
kernel/trace/trace_output.c:64: error: implicit declaration of function 'bstr_printf'
so i've excluded it from tip:master again for now.
Ingo
next prev parent reply other threads:[~2009-03-06 18:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 16:21 [PATCH 0/5 v3] Binary ftrace_printk Frederic Weisbecker
2009-03-06 16:21 ` [PATCH 1/5 v2] add binary printf Frederic Weisbecker
2009-03-06 16:50 ` Steven Rostedt
2009-03-06 17:00 ` [tip:core/printk] vsprintf: " Lai Jiangshan
2009-03-06 16:21 ` [PATCH 2/5 v3] ftrace: infrastructure for supporting binary record Frederic Weisbecker
2009-03-06 17:00 ` [tip:tracing/printk] tracing: " Lai Jiangshan
2009-03-06 16:21 ` [PATCH 3/5 v3] ftrace: add ftrace_bprintk() Frederic Weisbecker
2009-03-06 17:00 ` [tip:tracing/printk] tracing: add trace_bprintk() Lai Jiangshan
2009-03-06 16:21 ` [PATCH 4/5 v3] tracing/core: drop the old ftrace_printk implementation in favour of ftrace_bprintk Frederic Weisbecker
2009-03-06 16:49 ` Steven Rostedt
2009-03-06 17:02 ` Ingo Molnar
2009-03-06 17:14 ` Ingo Molnar
2009-03-06 18:04 ` Steven Rostedt
2009-03-06 18:49 ` Ingo Molnar [this message]
2009-03-06 19:09 ` Frederic Weisbecker
2009-03-06 19:17 ` Ingo Molnar
2009-03-06 17:14 ` Frederic Weisbecker
2009-03-06 17:01 ` [tip:tracing/printk] tracing/core: drop the old trace_printk() implementation in favour of trace_bprintk() Frederic Weisbecker
2009-03-06 17:01 ` [tip:tracing/printk] tracing: trace_bprintk() cleanups Ingo Molnar
2009-03-09 9:12 ` [tip:tracing/printk] tracing: trace_printk() fix, move format array to data section Ingo Molnar
2009-03-09 9:12 ` [tip:tracing/printk] tracing: optimize trace_printk() Ingo Molnar
2009-03-09 17:23 ` Steven Rostedt
2009-03-09 17:24 ` Steven Rostedt
2009-03-09 17:38 ` Frederic Weisbecker
2009-03-06 16:21 ` [PATCH 5/5 v3] vsprintf: unify the format decoding layer for its 3 users Frederic Weisbecker
2009-03-06 17:00 ` [tip:core/printk] " Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090306184904.GA24571@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox