public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Daniel Yeisley <dan.yeisley@unisys.com>
Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
	yinghai@kernel.org, stable@kernel.org, tglx@linutronix.de,
	linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/apic] x86: MSI: check for BIOS assigned addresses
Date: Fri, 6 Mar 2009 20:13:45 +0100	[thread overview]
Message-ID: <20090306191345.GD28582@elte.hu> (raw)
In-Reply-To: <1236364109.31604.10.camel@localhost.localdomain>


* Daniel Yeisley <dan.yeisley@unisys.com> wrote:

> On Fri, 2009-03-06 at 19:45 +0100, Ingo Molnar wrote:
> > * Daniel Yeisley <dan.yeisley@unisys.com> wrote:
> > 
> > > Commit-ID:  affd49d36e2e2df4cbb3e07a57db901c23823b6a
> > > Gitweb:     http://git.kernel.org/tip/affd49d36e2e2df4cbb3e07a57db901c23823b6a
> > > Author:     "Daniel Yeisley" <dan.yeisley@unisys.com>
> > > AuthorDate: Fri, 6 Mar 2009 10:11:49 -0500
> > > Commit:     Ingo Molnar <mingo@elte.hu>
> > > CommitDate: Fri, 6 Mar 2009 19:32:44 +0100
> > > 
> > > x86: MSI: check for BIOS assigned addresses
> > > 
> > > Impact: fix ACPI hotplug on certain systems
> > 
> > Note, this commit means that i moved the commit over from 
> > tip:x86/urgent into tip:x86/apic - i.e. with a 2.6.30 merge 
> > date. When exactly was this regression introduced? I think this 
> > code never really accepted the MSI settings from the firmware, 
> > so changing that behavior might affect a lot of systems.
> > 
> > So i'm uneasy about applying this fix this late in the .29 
> > cycle, but marked it for -stable backport so it could hit 
> > 2.6.29.1 if it stays problem-free.
> > 
> > 	Ingo
> 
> I initially noticed the problem on a 2.6.18 kernel.  ACPI 
> hotplugging didn't work unless I booted with pci=nomsi.  I 
> don't have a problem with waiting until 2.6.30 to make sure it 
> is thoroughly tested.

Okay - so it's an ancient bug. The current track should thus be 
fine.

Thanks,

	Ingo

  reply	other threads:[~2009-03-06 19:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-06 15:11 [PATCH] MSI: check for BIOS assigned addresses Daniel Yeisley
2009-03-06 16:24 ` Ingo Molnar
2009-03-06 15:56   ` Daniel Yeisley
2009-03-06 18:09 ` [tip:x86/urgent] x86: " Daniel Yeisley
2009-03-06 18:36 ` [tip:x86/apic] " Daniel Yeisley
2009-03-06 18:45   ` Ingo Molnar
2009-03-06 18:28     ` Daniel Yeisley
2009-03-06 19:13       ` Ingo Molnar [this message]
2009-03-07  1:06         ` Yinghai Lu
2009-03-08 10:54           ` Ingo Molnar
2009-03-09 14:32             ` Daniel Yeisley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090306191345.GD28582@elte.hu \
    --to=mingo@elte.hu \
    --cc=dan.yeisley@unisys.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=stable@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox