From: Andrey Borzenkov <arvidjaar@mail.ru>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] toshiba_acpi: Add full hotkey support
Date: Fri, 6 Mar 2009 21:57:10 +0300 [thread overview]
Message-ID: <200903062157.21021.arvidjaar@mail.ru> (raw)
In-Reply-To: <20090306184452.GA14375@srcf.ucam.org>
[-- Attachment #1: Type: text/plain, Size: 596 bytes --]
On 6 марта 2009 21:44:52 Matthew Garrett wrote:
> On Fri, Mar 06, 2009 at 09:37:50PM +0300, Andrey Borzenkov wrote:
> > Trivial cleanup below. Also the patch should remove
> > /proc/acpi/toshiba/keys. It will consume hot keys as soon as they
> > are pressed, so user space watching this file has very little
> > chances to ever see them.
>
> Mm. Actually, thinking about it, the cleanest thing to do would
> probably be to disable the input device when the proc file is opened.
C'mon, really. Let's make it depend on _DEPRECATED and obsolete in
2.6.31. Who needs this now?
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-03-06 18:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 0:39 [PATCH] toshiba_acpi: Add full hotkey support Matthew Garrett
2009-03-06 0:52 ` Matthew Garrett
2009-03-06 9:08 ` Richard Hughes
2009-03-06 9:47 ` Daniel Silverstone
2009-03-06 9:56 ` Matthew Garrett
2009-03-06 10:04 ` Daniel Silverstone
2009-03-06 10:09 ` Matthew Garrett
2009-03-06 10:12 ` Daniel Silverstone
2009-03-06 10:15 ` Matthew Garrett
2009-03-06 10:21 ` Daniel Silverstone
2009-03-06 18:49 ` Andrey Borzenkov
2009-03-06 18:53 ` Matthew Garrett
2009-03-06 18:37 ` Andrey Borzenkov
2009-03-06 18:44 ` Matthew Garrett
2009-03-06 18:57 ` Andrey Borzenkov [this message]
2009-03-07 7:27 ` Andrey Borzenkov
2009-03-07 15:06 ` Matthew Garrett
2009-03-07 15:38 ` Andrey Borzenkov
2009-03-07 15:44 ` Matthew Garrett
2009-03-07 20:19 ` Richard Hughes
2009-03-07 20:26 ` Matthew Garrett
2009-03-08 8:33 ` Richard Hughes
2009-03-08 14:29 ` Andrey Borzenkov
2009-03-08 14:36 ` Matthew Garrett
2009-03-09 17:11 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903062157.21021.arvidjaar@mail.ru \
--to=arvidjaar@mail.ru \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox