Re: [PATCH] toshiba_acpi: Add full hotkey support

Andrey Borzenkov
2009-03-06T18:49:55Z

Daniel Silverstone wrote:

> On Fri, 2009-03-06 at 10:15 +0000, Matthew Garrett wrote:
>> > I see. One other thing occurred to me. Is there any way for Hal to know
>> > that the notify stuff is in place and thus doesn't need to
>> > poll /proc/acpi/toshiba/keys? Otherwise it's going to poll it anyway
>> > which fails to remove the periodic wakeups.
>> No. Distributions should build without --enable-toshiba if they ship a
>> kernel with this functionaliy.
>
> This only makes sense if all the rest of /proc/acpi/toshiba/* is now
> implemented in proper modern kernel facilities.

I guess Matthew refers to HAL build switch. In which case only
/proc/acpi/toshiba/keys is relevant, other files are not used by this HAL
add-on.

In any case, as I mentioned, this file has to be removed if patch is
implemented as it is effectively no-op then.

> I noticed rfkill
> switches (although I'll have to see if another is needed for the HSDPA
> modems in modern laptops) and a proper brightness control. I assume
> xrandr does what video did, which just leaves the fan control.
>

There are two ways to control fan here - standard ACPI and HCI. ACPI does
not work. Is there any standard framework for fan control (a la
power_supply) where HCI version could be plugged in?