Re: [PATCH] toshiba_acpi: Add full hotkey support

Matthew Garrett
2009-03-07T15:06:53Z

On Sat, Mar 07, 2009 at 10:27:09AM +0300, Andrey Borzenkov wrote:
> Matthew Garrett wrote:
>
> > + {KE_KEY, 0x13d, KEY_SLEEP},
> > + {KE_KEY, 0x13e, KEY_SUSPEND},
>
> I have two buttons marked with memory and disk pictures. When I press the
> first one HAL emits "sleep" button event, for the the second one HAL emits
> "hibernate" event. I am using KDE4 and neither works :) According to KDE4
> developer, they implement "suspend" button as suspend to RAM. Just trying to
> clarify which key this should be and whether HAL should be fixed. (I opened
> bug report for KDE4)

Yeah, I'm not really a KDE guy, so I'm not sure what's happening there.

> > + {KE_KEY, 0x13f, KEY_SWITCHVIDEOMODE},
>
> I wonder, who is supposed to act upon it? Is there any generic user space
> agent who implements video output switching?

At present I don't believe so, no.

> > + {KE_KEY, 0x140, KEY_BRIGHTNESSDOWN},
> > + {KE_KEY, 0x141, KEY_BRIGHTNESSUP},
> > + {KE_KEY, 0x142, KEY_WLAN},
>
> Ditto. Theoretically Toshiba even supports turning off radio via HCI, but it
> is again not clear who should actually initiate it.

Right. In some of these cases there's nothing that currently handles
them, but userspace should probably get round to it at some point.

--
Matthew Garrett | mjg59@srcf.ucam.org