Re: [PATCH] toshiba_acpi: Add full hotkey support

Matthew Garrett
2009-03-07T15:44:39Z

On Sat, Mar 07, 2009 at 06:38:53PM +0300, Andrey Borzenkov wrote:

> - patch toshiba_acpi to return KEY_SUSPEND/KEY_HIBERNATE instead of
> KEY_SLEEP/KEY_SUSPEND. This depends on commit
> 6932b918e05b06165ed3457a9f3aa279099a7cbd in linux-next.
>
> - patch HAL to recognize KEY_HIBERNATE and return "suspend" for
> KEY_SUSPEND; right now it is:
>
> [KEY_SLEEP] = "sleep",
> [KEY_SUSPEND] = "hibernate",

Ugh. Why are we changing this? The semantics were pretty clear before.
The KEY_SUSPEND to hibernate mapping was decided years ago, and it's
clearly an incompatible change as far as userspace goes.

--
Matthew Garrett | mjg59@srcf.ucam.org