Re: [v3][PATCH 5/5] Merge code for singleandmultiple-instancemounts

H. Peter Anvin
2009-05-11T22:54:45Z

Serge E. Hallyn wrote:
> Quoting Sukadev Bhattiprolu (sukadev@linux.vnet.ibm.com):
> ...
>
>> >From 2f7746f4df78ff57125c4714f0cd64e739ccf804 Mon Sep 17 00:00:00 2001
>> From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
>> Date: Mon, 11 May 2009 13:11:11 -0700
>> Subject: [PATCH] devpts: Correctly set default options
>>
>> devpts_get_sb() calls memset(0) to clear mount options and calls
>> parse_mount_options() if user specified any mount options. The memset(0) is
>> bogus since the 'mode' and 'ptmxmode' options are non-zero by default.
>> parse_mount_options() restores options to default anyway and can properly deal
>> with NULL mount options.
>>
>> So in devpts_get_sb() remove memset(0) and call parse_mount_options() even for
>> NULL mount options.
>>
>> Bug reported by Eric Paris: http://lkml.org/lkml/2009/5/7/448.
>
> Would you almost say... Reported-by: ? :)
>> Signed-off-by: Sukadev Bhattiprolu (sukadev@us.ibm.com)
>
> Looks good.
>
> Acked-by: Serge Hallyn <serue@us.ibm.com>
>

Reviewed-by: H. Peter Anvin <hpa@zytor.com>

-hpa