Re: [v3][PATCH 5/5] Merge code for single and multiple-instance mounts

Sukadev Bhattiprolu
2009-05-07T21:24:34Z

Eric Paris [eparis@parisplace.org] wrote:
| On Sat, Mar 7, 2009 at 2:12 PM, Sukadev Bhattiprolu
| <sukadev@linux.vnet.ibm.com> wrote:
| >
| > From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
| > Subject: [v3][PATCH 5/5] Merge code for single and multiple-instance mounts
|
| I just tried to load the linux-next kernel on F11 and ran into a
| problem. X started, I could log in, I could start programs like
| firefox and evolution, but not gnome-terminal. It would just flash
| and disappear. Running xterm resulted in a window, that I could type
| in, but it wasn't a shell. It didn't do anything.
|
| I switched to vt2 set the display to my X session and tried to run
| xterm. It said something about a permission being denied, so I
| decided to strace it. I saw EACCESS returning from calls dealing with
| /dev/pts/0. This lead me to git bisect start fs/devpts from the
| latest in linux-next as bad and 2.6.29 as good. Couple interations
| later and I find that this commit (1bd7903560f1f7) breaks
| gnome-terminal xterm!

Interesting :-) -EACCESS makes me suspect that maybe 'mode' 'uid' or 'gid'
mount options are wrong. Of course we would still need to understand if/
why this patch changes the settings.

Can you paste the output of following commands: (both in success and failure
cases).

$ grep devpts /proc/mounts

$ ls -al /dev/pts

$ stat /dev/ptmx

Also, is CONFIG_DEVPTS_MULTIPLE_INSTANCES set in your .config ?

With this patch, does gnome-terminal run when logged in as root ?

Thanks,

Sukadev