From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Christoph Hellwig <hch@lst.de>, Andrew Morton <akpm@osdl.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: serue@us.ibm.com, hpa@zytor.com, sukadev@us.ibm.com,
linux-kernel@vger.kernel.org
Subject: [v3][PATCH 1/5] Unroll essentials of do_remount_sb() into devpts
Date: Sat, 7 Mar 2009 10:16:20 -0800 [thread overview]
Message-ID: <20090307181620.GA30380@us.ibm.com> (raw)
In-Reply-To: <20090307180816.GA30072@us.ibm.com>
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Subject: [v3][PATCH 1/5] Unroll essentials of do_remount_sb() into devpts
On remount, devpts fs only needs to parse the mount options. Users cannot
directly create/dirty files in /dev/pts so the MS_RDONLY flag and
shrinking the dcache does not really apply to devpts.
So effectively on remount, devpts only parses the mount options and updates
these options in its super block. As such, we could replace do_remount_sb()
call with a direct parse_mount_options().
Doing so enables subsequent patches to avoid parsing the mount options twice
and simplify the code.
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
---
fs/devpts/inode.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c
index ad186b4..de15e73 100644
--- a/fs/devpts/inode.c
+++ b/fs/devpts/inode.c
@@ -442,6 +442,8 @@ static int get_init_pts_sb(struct file_system_type *fs_type, int flags,
void *data, struct vfsmount *mnt)
{
struct super_block *s;
+ struct pts_mount_opts *opts;
+ struct pts_fs_info *fsi;
int error;
s = sget(fs_type, compare_init_pts_sb, set_anon_super, NULL);
@@ -458,7 +460,10 @@ static int get_init_pts_sb(struct file_system_type *fs_type, int flags,
}
s->s_flags |= MS_ACTIVE;
}
- do_remount_sb(s, flags, data, 0);
+ fsi = DEVPTS_SB(s);
+ opts = &fsi->mount_opts;
+ parse_mount_options(data, PARSE_REMOUNT, opts);
+
simple_set_mnt(mnt, s);
return 0;
}
--
1.5.2.5
prev parent reply other threads:[~2009-03-07 18:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-07 18:08 [PATCH 0/5][v2] Simplify devpts code Sukadev Bhattiprolu
2009-03-07 18:10 ` Sukadev Bhattiprolu
2009-03-07 18:17 ` Sukadev Bhattiprolu
2009-03-07 18:11 ` [v3][PATCH 2/5] Parse mount options just once and copy them to super block Sukadev Bhattiprolu
2009-03-07 18:11 ` [v3][PATCH 3/5] Move common mknod_ptmx() calls into caller Sukadev Bhattiprolu
2009-03-07 18:12 ` [v3][PATCH 4/5] Remove get_init_pts_sb() Sukadev Bhattiprolu
2009-03-07 18:12 ` [v3][PATCH 5/5] Merge code for single and multiple-instance mounts Sukadev Bhattiprolu
2009-05-07 20:35 ` Eric Paris
2009-05-07 21:24 ` Sukadev Bhattiprolu
2009-05-07 22:33 ` Eric Paris
2009-05-07 23:18 ` [v3][PATCH 5/5] Merge code for single and multiple-instancemounts Sukadev Bhattiprolu
2009-05-07 23:21 ` [v3][PATCH 5/5] Merge code for single andmultiple-instancemounts Sukadev Bhattiprolu
2009-05-08 13:53 ` Peter Staubach
2009-05-09 3:17 ` Marc Dionne
2009-05-11 22:15 ` Sukadev Bhattiprolu
2009-05-11 22:19 ` H. Peter Anvin
2009-05-11 22:37 ` [v3][PATCH 5/5] Merge code for singleandmultiple-instancemounts Serge E. Hallyn
2009-05-11 22:46 ` H. Peter Anvin
2009-05-11 22:40 ` [v3][PATCH 5/5] Merge code for single andmultiple-instancemounts Andrew Morton
2009-05-11 23:09 ` Eric Paris
2009-05-11 23:00 ` Marc Dionne
2009-03-07 18:14 ` [v3][PATCH 2/5] Parse mount options just once and copy them to super block Sukadev Bhattiprolu
2009-03-07 18:16 ` Sukadev Bhattiprolu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090307181620.GA30380@us.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=serue@us.ibm.com \
--cc=sukadev@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox