From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>
Cc: linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Re: ALSA HDA Intel stoped to work in 2.6.16-*
Date: Sat, 7 Mar 2009 19:00:44 +0100 [thread overview]
Message-ID: <200903071900.44762.rjw@sisk.pl> (raw)
In-Reply-To: <gou8k9$reh$1@ger.gmane.org>
(adding CCs).
Usually, sending such things to the LKML alone doesn't really work. Please
always send a CC to the relevant subsystem maintainer.
On Saturday 07 March 2009, Daniel Gimpelevich wrote:
> At Mon, 6 Mar 2006 15:16:15 +0100,
> Takashi Iwai wrote:
>
> > At Sat, 4 Mar 2006 15:51:14 +0100,
> > Adrian Bunk wrote:
> >>
> >> On Sat, Mar 04, 2006 at 02:29:02AM -0300, Otavio Salvador wrote:
> >> > Takashi Iwai <tiwai@suse.de> writes:
> >> >
> >> > > Are you sure that your device has PCI SUB-system id 8086:2668 ?
> >> >
> >> > oh no! Sorry!
> >> >
> >> > 0000:00:1b.0 0403: 8086:2668 (rev 04)
> >> > Subsystem: 152d:0729
> >> > ^^^^^^^^^
> >>
> >> Can you make a patch with the correct id test whether it fixes your
> >> problem (without model=basic)?
> >
> > This one should work for his device.
> >
> >
> > Takashi
> > ===
> >
> > [PATCH] Add default entry for CTL Travel Master U553W
> >
> > Added the default entry of ALC880 configuration table for
> > CTL Travel Master U553W.
> >
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> >
> > ---
> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> > index b767552..d5cd3a1 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -2948,6 +2948,8 @@ static struct hda_board_config alc260_cf
> > { .modelname = "basic", .config = ALC260_BASIC },
> > { .pci_subvendor = 0x104d, .pci_subdevice = 0x81bb,
> > .config = ALC260_BASIC }, /* Sony VAIO */
> > + { .pci_subvendor = 0x152d, .pci_subdevice = 0x0729,
> > + .config = ALC260_BASIC }, /* CTL Travel Master U553W */
> > { .modelname = "hp", .config = ALC260_HP },
> > { .pci_subvendor = 0x103c, .pci_subdevice = 0x3010, .config = ALC260_HP },
> > { .pci_subvendor = 0x103c, .pci_subdevice = 0x3011, .config = ALC260_HP },
>
> It has been three years since the above patch was posted with a request for
> testing. No testing reply ever appeared, and the patch was committed as
> submitted. On the relevant hardware, I determined the patch to be incorrect.
> For the git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
> head, the following patch appears to fix it correctly:
>
>
> Signed-off-by: Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 6c26afc..87ec806 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5692,7 +5692,7 @@ static struct snd_pci_quirk alc260_cfg_tbl[] = {
> SND_PCI_QUIRK(0x104d, 0x81cc, "Sony VAIO", ALC260_BASIC),
> SND_PCI_QUIRK(0x104d, 0x81cd, "Sony VAIO", ALC260_BASIC),
> SND_PCI_QUIRK(0x10cf, 0x1326, "Fujitsu S702X", ALC260_FUJITSU_S702X),
> - SND_PCI_QUIRK(0x152d, 0x0729, "CTL U553W", ALC260_BASIC),
> + SND_PCI_QUIRK(0x152d, 0x0729, "CTL U553W", ALC260_WILL),
> SND_PCI_QUIRK(0x161f, 0x2057, "Replacer 672V", ALC260_REPLACER_672V),
> SND_PCI_QUIRK(0x1631, 0xc017, "PB V7900", ALC260_WILL),
> {}
>
> --
next prev parent reply other threads:[~2009-03-07 18:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-27 13:15 ALSA HDA Intel stoped to work in 2.6.16-* Otavio Salvador
2006-02-27 14:49 ` Diego Calleja
2006-02-28 8:34 ` Otavio Salvador
2006-02-27 15:02 ` Takashi Iwai
2006-02-28 8:51 ` Otavio Salvador
2006-02-28 10:54 ` Takashi Iwai
2006-02-28 20:28 ` Otavio Salvador
2006-03-01 10:29 ` Takashi Iwai
2006-03-02 2:24 ` Otavio Salvador
2006-03-03 18:11 ` Takashi Iwai
2006-03-04 5:29 ` Otavio Salvador
2006-03-04 14:51 ` Adrian Bunk
2006-03-06 14:16 ` Takashi Iwai
2009-03-07 16:50 ` [PATCH] " Daniel Gimpelevich
2009-03-07 18:00 ` Rafael J. Wysocki [this message]
2009-03-08 10:26 ` Takashi Iwai
2009-03-08 23:21 ` Daniel Gimpelevich
2009-03-11 8:33 ` Takashi Iwai
2009-03-11 13:07 ` Daniel Gimpelevich
2009-03-11 13:27 ` Takashi Iwai
2009-03-11 13:53 ` Daniel Gimpelevich
2006-03-04 15:00 ` [2.6 patch] ALSA-Configuration.txt: snd-hda-intel: document model=basic Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903071900.44762.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=daniel@gimpelevich.san-francisco.ca.us \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox