Re: [PATCH] PCIe: portdrv: call pci_disable_device during remove

Rafael J. Wysocki
2009-03-09T21:28:42Z

On Sunday 08 March 2009, Alex Chiang wrote:
> The PCIe port driver calls pci_enable_device when registering
> ports, but never calls pci_disable_device during removal.
>
> Signed-off-by: Alex Chiang <achiang@hp.com>

Acked-by: Rafael J. Wysocki <rjw@sisk.pl>

> ---
> This patch is against jbarnes's linux-next branch.
> ---
> diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c
> index 5a5bfe7..e399825 100644
> --- a/drivers/pci/pcie/portdrv_core.c
> +++ b/drivers/pci/pcie/portdrv_core.c
> @@ -473,6 +473,7 @@ void pcie_port_device_remove(struct pci_dev *dev)
> struct pcie_port_data *port_data = pci_get_drvdata(dev);
>
> device_for_each_child(&dev->dev, NULL, remove_iter);
> + pci_disable_device(dev);
>
> switch (port_data->port_irq_mode) {
> case PCIE_PORT_MSIX_MODE:
> --