public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Chiang <achiang@hp.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>,
	linux-pci <linux-pci@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Cc: rjw@sisk.pl
Subject: Re: [PATCH] PCIe: portdrv: call pci_disable_device during remove
Date: Sun, 8 Mar 2009 18:29:55 -0600	[thread overview]
Message-ID: <20090309002955.GA23137@ldl.fc.hp.com> (raw)
In-Reply-To: <20090308044649.GC3575@ldl.fc.hp.com>

Forgot to cc Rafael on this one.

/ac

* Alex Chiang <achiang@hp.com>:
> The PCIe port driver calls pci_enable_device when registering
> ports, but never calls pci_disable_device during removal.
> 
> Signed-off-by: Alex Chiang <achiang@hp.com>
> ---
> This patch is against jbarnes's linux-next branch.
> ---
> diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c
> index 5a5bfe7..e399825 100644
> --- a/drivers/pci/pcie/portdrv_core.c
> +++ b/drivers/pci/pcie/portdrv_core.c
> @@ -473,6 +473,7 @@ void pcie_port_device_remove(struct pci_dev *dev)
>  	struct pcie_port_data *port_data = pci_get_drvdata(dev);
>  
>  	device_for_each_child(&dev->dev, NULL, remove_iter);
> +	pci_disable_device(dev);
>  
>  	switch (port_data->port_irq_mode) {
>  	case PCIE_PORT_MSIX_MODE:
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

  reply	other threads:[~2009-03-09  0:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-08  4:46 [PATCH] PCIe: portdrv: call pci_disable_device during remove Alex Chiang
2009-03-09  0:29 ` Alex Chiang [this message]
2009-03-09 21:28 ` Rafael J. Wysocki
  -- strict thread matches above, loose matches on Subject: below --
2009-03-08  2:35 Alex Chiang
2009-03-08 10:17 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090309002955.GA23137@ldl.fc.hp.com \
    --to=achiang@hp.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox