From: Matthias Kaehlcke <matthias@kaehlcke.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-arm-kernel@lists.arm.linux.org.uk,
linux-kernel@vger.kernel.org,
Abhishek Sagar <sagar.abhishek@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Steven Rostedt <rostedt@rostedt.homelinux.com>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] ftrace: fix crash due to tracing of __naked functions
Date: Mon, 9 Mar 2009 11:27:30 +0100 [thread overview]
Message-ID: <20090309102730.GA32492@traven> (raw)
In-Reply-To: <1236584800-7686-1-git-send-email-u.kleine-koenig@pengutronix.de>
El Mon, Mar 09, 2009 at 08:46:40AM +0100 Uwe Kleine-König ha dit:
> This is a fix for the following crash observed in 2.6.29-rc3:
> http://lkml.org/lkml/2009/1/29/150
>
> On ARM it doesn't make sense to trace a naked function because then
> mcount is called without stack and frame pointer being set up and there
> is no chance to restore the lr register to the value before mcount was
> called.
>
> Compared to the original fix posted to arm-linux-kernel ML on 29 Jan
> 2009 by Abhishek Sagar I only changed the definition of __naked for ARM.
>
> Reported-by: Matthias Kaehlcke <matthias@kaehlcke.net>
> Cc: Abhishek Sagar <sagar.abhishek@gmail.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Steven Rostedt <rostedt@home.goodmis.org>
> Cc: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> without this change a kernel having CONFIG_FUNCTION_TRACER=y doesn't
> boot on many maschines. It would be great if this change would make it
> into .29.
i agree that it would be convenient to have this resolved in .29
Tested-by: Matthias Kaehlcke <matthias@kaehlcke.net>
--
Matthias Kaehlcke
Embedded Linux Engineer
Barcelona
The salvation of mankind lies only in making everything the concern of all
(Alexander Solzhenitsyn)
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-
next prev parent reply other threads:[~2009-03-09 10:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-09 7:46 [PATCH] ftrace: fix crash due to tracing of __naked functions Uwe Kleine-König
2009-03-09 10:27 ` Matthias Kaehlcke [this message]
2009-03-09 20:38 ` Uwe Kleine-König
2009-03-15 1:44 ` Tim Bird
2009-03-15 6:34 ` Uwe Kleine-König
2009-03-15 8:57 ` Russell King - ARM Linux
2009-03-16 16:33 ` Tim Bird
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090309102730.GA32492@traven \
--to=matthias@kaehlcke.net \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@elte.hu \
--cc=rostedt@rostedt.homelinux.com \
--cc=sagar.abhishek@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox