From: Oleg Nesterov <oleg@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Roland McGrath <roland@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Chris Evans <scarybeasts@gmail.com>,
Don Howard <dhoward@redhat.com>, Eugene Teo <eugene@redhat.com>,
Michael Kerrisk <mtk.manpages@googlemail.com>,
Tavis Ormandy <taviso@sdf.lonestar.org>,
Vitaly Mayatskikh <vmayatsk@redhat.com>,
stable@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] copy_process: fix CLONE_PARENT && parent_exec_id interaction
Date: Mon, 9 Mar 2009 19:33:56 +0100 [thread overview]
Message-ID: <20090309183356.GA32432@redhat.com> (raw)
In-Reply-To: <2712.1236617156@redhat.com>
On 03/09, David Howells wrote:
>
> Oleg Nesterov <oleg@redhat.com> wrote:
>
> > - /* Our parent execution domain becomes current domain
> > - These must match for thread signalling to apply */
>
> Should you retain this comment somewhere?
This comment should be changed, but I failed to make the new one.
Actually, this was one of the reasons why the first patch I sent
http://marc.info/?l=linux-kernel&m=123602926516698
didn't touch the first ""p->parent_exec_id = ...".
There is a fat comment in exit_notify(), perhaps we can just add
/* see the comment in exit_notify() */.
But the "good" commenent should also explain that, since we re-use
->real_parent, the child also "inherits" the rights _and_ restrictions
to send ->exit_signal != SIGCHLD.
Oleg.
prev parent reply other threads:[~2009-03-09 18:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 19:02 [PATCH 1/2] copy_process: fix CLONE_PARENT && ->exit_signal interaction Oleg Nesterov
2009-02-25 19:39 ` Roland McGrath
2009-02-25 19:48 ` Oleg Nesterov
2009-02-25 19:54 ` Roland McGrath
2009-02-25 20:06 ` Linus Torvalds
2009-02-25 21:20 ` Oleg Nesterov
2009-02-25 21:34 ` [stable] " Greg KH
2009-02-26 21:59 ` Oleg Nesterov
2009-02-26 22:12 ` Linus Torvalds
2009-02-26 22:30 ` Oleg Nesterov
2009-02-26 22:43 ` Linus Torvalds
2009-03-02 21:22 ` [PATCH] copy_process: fix CLONE_PARENT && parent_exec_id interaction Oleg Nesterov
2009-03-02 21:33 ` Linus Torvalds
2009-03-02 21:58 ` Oleg Nesterov
2009-03-09 16:45 ` David Howells
2009-03-09 18:33 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090309183356.GA32432@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dhoward@redhat.com \
--cc=dhowells@redhat.com \
--cc=eugene@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@googlemail.com \
--cc=roland@redhat.com \
--cc=scarybeasts@gmail.com \
--cc=stable@kernel.org \
--cc=taviso@sdf.lonestar.org \
--cc=torvalds@linux-foundation.org \
--cc=vmayatsk@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox