public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Chiang <achiang@hp.com>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Matthew Wilcox <matthew@wil.cx>, Greg KH <greg@kroah.com>,
	kay.sievers@vrfy.org, rjw@sisk.pl, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org
Subject: Re: kobj refcounting weirdness
Date: Mon, 9 Mar 2009 12:41:31 -0600	[thread overview]
Message-ID: <20090309184131.GI32589@ldl.fc.hp.com> (raw)
In-Reply-To: <19f34abd0903091121g73d6cdeeqfa8353b55a3e9607@mail.gmail.com>

* Vegard Nossum <vegard.nossum@gmail.com>:
> 2009/3/9 Alex Chiang <achiang@hp.com>:
> > * Matthew Wilcox <matthew@wil.cx>:
> >> On Mon, Mar 09, 2009 at 10:50:10AM -0600, Alex Chiang wrote:
> >> > I thought about the allocators returning a pointer to the same
> >> > location that maybe has some valid looking data hanging around,
> >> > but it's not wise for someone like me to go pointing fingers at
> >> > the allocator before I've proven the bug isn't in my code. ;)
> >>
> >> Slab poisoning would be the logical next thing to try to decide whether
> >> the allocator is wrong or you're using it wrong ;-)
> >
> > We had a double free in the PCIe port driver. Removing the double
> > free seems to fix my issue.
> >
> > The double free is only in Jesse's linux-next branch, so no need
> > to worry about it in mainline/stable.
> 
> Sorry for butting in, just wondering if I could have the patch to fix
> the double free? :-)

http://thread.gmane.org/gmane.linux.kernel.pci/3524

Remember, it only applies to Jesse's linux-next, since it has
Rafael's latest port driver cleanups.

If you apply it to mainline, you will leak memory.

Thanks.

/ac


      reply	other threads:[~2009-03-09 18:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-09  6:36 kobj refcounting weirdness Alex Chiang
2009-03-09 15:04 ` Greg KH
2009-03-09 15:05   ` Greg KH
2009-03-09 16:50   ` Alex Chiang
2009-03-09 16:58     ` Matthew Wilcox
2009-03-09 17:21       ` Alex Chiang
2009-03-09 18:01       ` Alex Chiang
2009-03-09 18:21         ` Vegard Nossum
2009-03-09 18:41           ` Alex Chiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090309184131.GI32589@ldl.fc.hp.com \
    --to=achiang@hp.com \
    --cc=greg@kroah.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=rjw@sisk.pl \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox