From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Alex Chiang <achiang@hp.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
"linux-pci" <linux-pci@vger.kernel.org>,
"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCIe portdrv: eliminate double kfree in remove path
Date: Mon, 9 Mar 2009 22:19:37 +0100 [thread overview]
Message-ID: <200903092219.37414.rjw@sisk.pl> (raw)
In-Reply-To: <20090309180815.GH32589@ldl.fc.hp.com>
On Monday 09 March 2009, Alex Chiang wrote:
> Commit 55633af3 (PCIe portdrv: Use driver data to simplify code)
> added a kfree of the driver private data in pcie_port_device_remove
> but forgot to remove the old kfree from pcie_portdrv_remove.
Ah, sorry for that, it resulted in quite a lot of debugging work for you. :-(
> Signed-off-by: Alex Chiang <achiang@hp.com>
Acked-by; Rafael J. Wysocki <rjw@sisk.pl>
> ---
> diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
> index a6fee6c..f2368b1 100644
> --- a/drivers/pci/pcie/portdrv_pci.c
> +++ b/drivers/pci/pcie/portdrv_pci.c
> @@ -93,7 +93,6 @@ static int __devinit pcie_portdrv_probe (struct pci_dev *dev,
> static void pcie_portdrv_remove (struct pci_dev *dev)
> {
> pcie_port_device_remove(dev);
> - kfree(pci_get_drvdata(dev));
> }
>
> static int error_detected_iter(struct device *device, void *data)
> --
next prev parent reply other threads:[~2009-03-09 21:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-09 18:08 [PATCH] PCIe portdrv: eliminate double kfree in remove path Alex Chiang
2009-03-09 21:19 ` Rafael J. Wysocki [this message]
2009-03-20 1:43 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903092219.37414.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=achiang@hp.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox