* [PATCH 1/2 -mmotm] debug-pagealloc: depend on CONFIG_DEBUG_KERNEL
@ 2009-03-10 14:37 Akinobu Mita
2009-03-10 14:38 ` [PATCH 2/2 -mmotm] debug-pagealloc: cannot depend on hibernation Akinobu Mita
0 siblings, 1 reply; 2+ messages in thread
From: Akinobu Mita @ 2009-03-10 14:37 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-arch, akpm
The generic debug-pagealloc should depend on CONFIG_DEBUG_KERNEL
as well as the architecture specific one.
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-arch@vger.kernel.org
---
mm/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: 2.6-mmotm/mm/Kconfig.debug
===================================================================
--- 2.6-mmotm.orig/mm/Kconfig.debug
+++ 2.6-mmotm/mm/Kconfig.debug
@@ -3,7 +3,7 @@ config WANT_PAGE_DEBUG_FLAGS
config PAGE_POISONING
bool "Debug page memory allocations"
- depends on !ARCH_SUPPORTS_DEBUG_PAGEALLOC
+ depends on DEBUG_KERNEL && !ARCH_SUPPORTS_DEBUG_PAGEALLOC
select DEBUG_PAGEALLOC
select WANT_PAGE_DEBUG_FLAGS
help
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 2/2 -mmotm] debug-pagealloc: cannot depend on hibernation
2009-03-10 14:37 [PATCH 1/2 -mmotm] debug-pagealloc: depend on CONFIG_DEBUG_KERNEL Akinobu Mita
@ 2009-03-10 14:38 ` Akinobu Mita
0 siblings, 0 replies; 2+ messages in thread
From: Akinobu Mita @ 2009-03-10 14:38 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-arch, akpm
The generic debug-pagealloc generates wrong messages for the page corruption
after hibernation. Because the free pages are not saved to the suspend image.
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: <linux-arch@vger.kernel.org>
---
mm/Kconfig.debug | 5 +++++
1 file changed, 5 insertions(+)
Index: 2.6-mmotm/mm/Kconfig.debug
===================================================================
--- 2.6-mmotm.orig/mm/Kconfig.debug
+++ 2.6-mmotm/mm/Kconfig.debug
@@ -4,9 +4,14 @@ config WANT_PAGE_DEBUG_FLAGS
config PAGE_POISONING
bool "Debug page memory allocations"
depends on DEBUG_KERNEL && !ARCH_SUPPORTS_DEBUG_PAGEALLOC
+ depends on !HIBERNATION
select DEBUG_PAGEALLOC
select WANT_PAGE_DEBUG_FLAGS
help
Fill the pages with poison patterns after free_pages() and verify
the patterns before alloc_pages(). This results in a large slowdown,
but helps to find certain types of memory corruptions.
+
+ This option cannot enalbe with hibernation. Otherwise, it will get
+ wrong messages for memory corruption because the free pages are not
+ saved to the suspend image.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-10 14:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-10 14:37 [PATCH 1/2 -mmotm] debug-pagealloc: depend on CONFIG_DEBUG_KERNEL Akinobu Mita
2009-03-10 14:38 ` [PATCH 2/2 -mmotm] debug-pagealloc: cannot depend on hibernation Akinobu Mita
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox