From: Andy Whitcroft <apw@shadowen.org>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: Joel Schopp <jschopp@austin.ibm.com>,
Randy Dunlap <rdunlap@xenotime.net>,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch and pr_fmt()?
Date: Tue, 10 Mar 2009 18:36:10 +0000 [thread overview]
Message-ID: <20090310183610.GE28243@shadowen.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0812181718250.1445@vixen.sonytel.be>
On Thu, Dec 18, 2008 at 05:24:06PM +0100, Geert Uytterhoeven wrote:
> When using the recently introduced pr_fmt() infrastructure (commit
> d091c2f58ba32029495a933b721e8e02fbd12caa, "Add 'pr_fmt()' format modifier to
> pr_xyz macros."), checkpatch spits out the following annoying error:
>
> | ERROR: Macros with complex values should be enclosed in parenthesis
> | +#define pr_fmt(fmt) "%s: " fmt, __func__
>
> Unfortunately, adding parentheses is not a solution, as it creates illegal C
> code.
Yeah that one looks like something we should avoid. Fixed in my next
update which can be tested here:
http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing
-apw
prev parent reply other threads:[~2009-03-10 19:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 16:24 checkpatch and pr_fmt()? Geert Uytterhoeven
2009-03-10 18:36 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090310183610.GE28243@shadowen.org \
--to=apw@shadowen.org \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox