From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755162AbZCKBB3 (ORCPT ); Tue, 10 Mar 2009 21:01:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752877AbZCKBBU (ORCPT ); Tue, 10 Mar 2009 21:01:20 -0400 Received: from mga03.intel.com ([143.182.124.21]:25222 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752965AbZCKBBT (ORCPT ); Tue, 10 Mar 2009 21:01:19 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.38,338,1233561600"; d="scan'208";a="118934607" Date: Wed, 11 Mar 2009 09:00:04 +0800 From: Wu Fengguang To: Andrew Morton Cc: Linus Torvalds , stable@kernel.org, LKML , Matt Mackall , Alexey Dobriyan Subject: [PATCH] proc: fix kflags to uflags copying in /proc/kpageflags Message-ID: <20090311010004.GA8237@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix kpf_copy_bit(src,dst) to be kpf_copy_bit(dst,src) to match the actual call patterns, e.g. kpf_copy_bit(kflags, KPF_LOCKED, PG_locked). This misplacement of src/dst only affected reporting of PG_writeback, PG_reclaim and PG_buddy. For others kflags==uflags so not affected. Signed-off-by: Wu Fengguang --- This is a tested and trivial no-side-effect fix. I'd suggest it for 2.6.29-rc7 and 2.6.28.X kernels. diff --git a/fs/proc/page.c b/fs/proc/page.c index 2d13451..e998383 100644 --- a/fs/proc/page.c +++ b/fs/proc/page.c @@ -80,7 +80,7 @@ static const struct file_operations proc_kpagecount_operations = { #define KPF_RECLAIM 9 #define KPF_BUDDY 10 -#define kpf_copy_bit(flags, srcpos, dstpos) (((flags >> srcpos) & 1) << dstpos) +#define kpf_copy_bit(flags, dstpos, srcpos) (((flags >> srcpos) & 1) << dstpos) static ssize_t kpageflags_read(struct file *file, char __user *buf, size_t count, loff_t *ppos)