Re: [v1 PATCH 1/1] PCI: Add AMD8111 PCI Bridge PCI Device ID

Greg KH
2009-03-11T04:38:11Z

On Tue, Mar 10, 2009 at 09:26:12AM +0800, Harry Ciao wrote:
> Greg KH 写道:
>> On Mon, Mar 09, 2009 at 05:09:03PM +0800, Harry Ciao wrote:
>>
>>> Add the PCI Device ID for the PCI Bridge Controller on AMD8111 chip,
>>> which is used by AMD8111 EDAC driver.
>>>
>>
>> Where is the corrisponding change to the edac driver to use this new id?
>>
>>
> This new id is to be used in the newly added edac driver amd8111_edac.c
> that I have posted to the mailing list on March 9th, it is used to probe
> the PCI Bridge Controller on AMD8111 chip.

So that patch depends on this one? You should just use the device id
within your driver, no need to modify this header file at all.

>> And for ids that are only in one driver, there is no need to add them to
>> the pci_ids.h file. This is what we have been doing for the past few
>> years in order to cut down on the merge-mess in the pci_ids.h file for
>> no reason.
>>
> Ok, I see for the time being I had better define this new id as a macro in
> amd8111_edac.c.

Yes, as a permanent solution.

> And I am a little curious that do you mean that pci_ids.h maintainer
> would have to track how many times a new id have been requested to
> decide if to merge it into the file or not?

No, someone would notice it and submit such a patch.

thanks,

greg k-h