From: Ingo Molnar <mingo@elte.hu>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Sam Ravnborg <sam@ravnborg.org>, Andrew Morton <akpm@osdl.org>,
Steven Rostedt <srostedt@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kallsyms, tracing: output more proper symbol name
Date: Wed, 11 Mar 2009 10:46:21 +0100 [thread overview]
Message-ID: <20090311094621.GA13543@elte.hu> (raw)
In-Reply-To: <49B7863F.6020804@cn.fujitsu.com>
* Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
> +#define VMLINUX_SYMBOL(_sym_) #_sym_
> +
> +static const char *hide_symbols[] = {
> + /* misc symbols */
> + "_text",
> + "_stext",
> + "_etext",
> + "_sinittext",
> + "_einittext",
> +
> + /* symbols from include/asm-generic/vmlinux.lds.h */
> + VMLINUX_SYMBOL(__start_mcount_loc),
> + VMLINUX_SYMBOL(__stop_mcount_loc),
> + VMLINUX_SYMBOL(__start_annotated_branch_profile),
> + VMLINUX_SYMBOL(__stop_annotated_branch_profile),
> + VMLINUX_SYMBOL(__start_branch_profile),
> + VMLINUX_SYMBOL(__stop_branch_profile),
> + VMLINUX_SYMBOL(__start___markers),
> + VMLINUX_SYMBOL(__stop___markers),
> + VMLINUX_SYMBOL(__start___tracepoints),
> + VMLINUX_SYMBOL(__stop___tracepoints),
> + VMLINUX_SYMBOL(__start_rodata),
> + VMLINUX_SYMBOL(__start_pci_fixups_early),
> + VMLINUX_SYMBOL(__end_pci_fixups_early),
> + VMLINUX_SYMBOL(__start_pci_fixups_header),
> + VMLINUX_SYMBOL(__end_pci_fixups_header),
> + VMLINUX_SYMBOL(__start_pci_fixups_final),
> + VMLINUX_SYMBOL(__end_pci_fixups_final),
> + VMLINUX_SYMBOL(__start_pci_fixups_enable),
> + VMLINUX_SYMBOL(__end_pci_fixups_enable),
> + VMLINUX_SYMBOL(__start_pci_fixups_resume),
> + VMLINUX_SYMBOL(__end_pci_fixups_resume),
> + VMLINUX_SYMBOL(__start_pci_fixups_resume_early),
> + VMLINUX_SYMBOL(__end_pci_fixups_resume_early),
> + VMLINUX_SYMBOL(__start_pci_fixups_suspend),
> + VMLINUX_SYMBOL(__end_pci_fixups_suspend),
> + VMLINUX_SYMBOL(__start_builtin_fw),
> + VMLINUX_SYMBOL(__end_builtin_fw),
> + VMLINUX_SYMBOL(__start_rio_route_ops),
> + VMLINUX_SYMBOL(__end_rio_route_ops),
> + VMLINUX_SYMBOL(__start___ksymtab),
> + VMLINUX_SYMBOL(__stop___ksymtab),
> + VMLINUX_SYMBOL(__start___ksymtab_gpl),
> + VMLINUX_SYMBOL(__stop___ksymtab_gpl),
> + VMLINUX_SYMBOL(__start___ksymtab_unused),
> + VMLINUX_SYMBOL(__stop___ksymtab_unused),
> + VMLINUX_SYMBOL(__start___ksymtab_unused_gpl),
> + VMLINUX_SYMBOL(__stop___ksymtab_unused_gpl),
> + VMLINUX_SYMBOL(__start___ksymtab_gpl_future),
> + VMLINUX_SYMBOL(__stop___ksymtab_gpl_future),
> + VMLINUX_SYMBOL(__start___kcrctab),
> + VMLINUX_SYMBOL(__stop___kcrctab),
> + VMLINUX_SYMBOL(__start___kcrctab_gpl),
> + VMLINUX_SYMBOL(__stop___kcrctab_gpl),
> + VMLINUX_SYMBOL(__start___kcrctab_unused),
> + VMLINUX_SYMBOL(__stop___kcrctab_unused),
> + VMLINUX_SYMBOL(__start___kcrctab_unused_gpl),
> + VMLINUX_SYMBOL(__stop___kcrctab_unused_gpl),
> + VMLINUX_SYMBOL(__start___kcrctab_gpl_future),
> + VMLINUX_SYMBOL(__stop___kcrctab_gpl_future),
> + VMLINUX_SYMBOL(__start___param),
> + VMLINUX_SYMBOL(__stop___param),
> + VMLINUX_SYMBOL(__end_rodata),
> + VMLINUX_SYMBOL(__security_initcall_start),
> + VMLINUX_SYMBOL(__security_initcall_end),
> + VMLINUX_SYMBOL(__sched_text_start),
> + VMLINUX_SYMBOL(__sched_text_end),
> + VMLINUX_SYMBOL(__lock_text_start),
> + VMLINUX_SYMBOL(__lock_text_end),
> + VMLINUX_SYMBOL(__kprobes_text_start),
> + VMLINUX_SYMBOL(__kprobes_text_end),
> + VMLINUX_SYMBOL(__irqentry_text_start),
> + VMLINUX_SYMBOL(__irqentry_text_end),
> + VMLINUX_SYMBOL(__start___verbose_strings),
> + VMLINUX_SYMBOL(__stop___verbose_strings),
> + VMLINUX_SYMBOL(__start___verbose),
> + VMLINUX_SYMBOL(__stop___verbose),
> + VMLINUX_SYMBOL(__start___bug_table),
> + VMLINUX_SYMBOL(__stop___bug_table),
> + VMLINUX_SYMBOL(__tracedata_start),
> + VMLINUX_SYMBOL(__tracedata_end),
> + VMLINUX_SYMBOL(__start_notes),
> + VMLINUX_SYMBOL(__stop_notes),
> + VMLINUX_SYMBOL(__early_initcall_end),
> + VMLINUX_SYMBOL(__per_cpu_start),
> + VMLINUX_SYMBOL(__per_cpu_end)
> +};
I like how you try to solve this at symbol table generation
time.
Instead of this hardcoded table, couldnt we use some more
flexible and more future-proof method? Such as ordering
same-address symbols by underscores:
[same address]
non-underscore symbols first XYZ
single-undescroe symbols second _XYZ
double-underscore symbols third __XYZ
that way the scheme would be more or less self-maintaining as an
underscore already carries a "this is a special, internal
symbol" notion.
Ingo
next prev parent reply other threads:[~2009-03-11 9:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 9:37 [PATCH] kallsyms, tracing: output more proper symbol name Lai Jiangshan
2009-03-11 9:46 ` Ingo Molnar [this message]
2009-03-11 10:29 ` Frederic Weisbecker
2009-03-11 13:05 ` Paulo Marques
2009-03-12 2:43 ` Lai Jiangshan
2009-03-12 15:32 ` Paulo Marques
2009-03-13 7:10 ` [PATCH V3] " Lai Jiangshan
2009-03-13 9:27 ` Lai Jiangshan
2009-03-13 19:25 ` Paulo Marques
2009-03-13 19:40 ` Sam Ravnborg
2009-03-13 20:07 ` Andrew Morton
2009-03-13 20:34 ` Paulo Marques
2009-03-14 8:54 ` Ingo Molnar
2009-03-14 8:57 ` [tip:tracing/ftrace] " Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090311094621.GA13543@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox