From: Magnus Damm <magnus.damm@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, lethal@linux-sh.org,
tglx@linutronix.de, Magnus Damm <magnus.damm@gmail.com>,
mingo@elte.hu
Subject: [PATCH 02/03] Match remove_irq() args with setup_irq()
Date: Thu, 12 Mar 2009 21:05:51 +0900 [thread overview]
Message-ID: <20090312120551.2926.43942.sendpatchset@rx1.opensource.se> (raw)
In-Reply-To: <20090312120534.2926.78511.sendpatchset@rx1.opensource.se>
From: Magnus Damm <damm@igel.co.jp>
Modify remove_irq() to match setup_irq().
Signed-off-by: Magnus Damm <damm@igel.co.jp>
---
include/linux/irq.h | 2 +-
kernel/irq/manage.c | 26 +++++++++++++++++---------
2 files changed, 18 insertions(+), 10 deletions(-)
--- 0002/include/linux/irq.h
+++ work/include/linux/irq.h 2009-03-12 20:30:10.000000000 +0900
@@ -228,7 +228,7 @@ typedef struct irq_desc irq_desc_t;
#include <asm/hw_irq.h>
extern int setup_irq(unsigned int irq, struct irqaction *new);
-extern struct irqaction *remove_irq(unsigned int irq, void *dev_id);
+extern void remove_irq(unsigned int irq, struct irqaction *act);
#ifdef CONFIG_GENERIC_HARDIRQS
--- 0002/kernel/irq/manage.c
+++ work/kernel/irq/manage.c 2009-03-12 20:31:05.000000000 +0900
@@ -550,15 +550,11 @@ int setup_irq(unsigned int irq, struct i
return __setup_irq(irq, desc, act);
}
-/**
- * remove_irq - free an interrupt
- * @irq: Interrupt line to free
- * @dev_id: Device identity to free
- *
- * Used to remove interrupts statically setup by the early boot process.
+ /*
+ * Internal function to unregister an irqaction - used to free
+ * regular and special interrupts that are part of the architecture.
*/
-
-struct irqaction *remove_irq(unsigned int irq, void *dev_id)
+static struct irqaction *__free_irq(unsigned int irq, void *dev_id)
{
struct irq_desc *desc = irq_to_desc(irq);
struct irqaction *action, **action_ptr;
@@ -634,6 +630,18 @@ struct irqaction *remove_irq(unsigned in
}
/**
+ * remove_irq - free an interrupt
+ * @irq: Interrupt line to free
+ * @act: irqaction for the interrupt
+ *
+ * Used to remove interrupts statically setup by the early boot process.
+ */
+void remove_irq(unsigned int irq, struct irqaction *act)
+{
+ __free_irq(irq, act->dev_id);
+}
+
+/**
* free_irq - free an interrupt allocated with request_irq
* @irq: Interrupt line to free
* @dev_id: Device identity to free
@@ -649,7 +657,7 @@ struct irqaction *remove_irq(unsigned in
*/
void free_irq(unsigned int irq, void *dev_id)
{
- kfree(remove_irq(irq, dev_id));
+ kfree(__free_irq(irq, dev_id));
}
EXPORT_SYMBOL(free_irq);
next prev parent reply other threads:[~2009-03-12 12:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 12:05 [PATCH 00/03] Free setup_irq() interrupt V3 Magnus Damm
2009-03-12 12:05 ` [PATCH 01/03] Add remove_irq() for freeing of setup_irq() irqs Magnus Damm
2009-03-12 23:06 ` [tip:irq/genirq] irq: add " Magnus Damm
2009-03-12 12:05 ` Magnus Damm [this message]
2009-03-12 23:06 ` [tip:irq/genirq] irq: match remove_irq() args with setup_irq() Magnus Damm
2009-03-12 12:05 ` [PATCH 03/03] Export remove_irq() and setup_irq() symbols Magnus Damm
2009-03-12 23:06 ` [tip:irq/genirq] irq: export " Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090312120551.2926.43942.sendpatchset@rx1.opensource.se \
--to=magnus.damm@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox