From: Ingo Molnar <mingo@elte.hu>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Subject: Re: [PATCH 1/2] x86: unify kmap_atomic_pfn() and iomap_atomic_prot_pfn()
Date: Thu, 12 Mar 2009 13:24:27 +0100 [thread overview]
Message-ID: <20090312122427.GA24295@elte.hu> (raw)
In-Reply-To: <961aa3350903111728m6203106tf74a767f1a82e663@mail.gmail.com>
* Akinobu Mita <akinobu.mita@gmail.com> wrote:
> 2009/3/12 Ingo Molnar <mingo@elte.hu>:
> >
> > * Akinobu Mita <akinobu.mita@gmail.com> wrote:
> >
> >> 2009/3/12 Thomas Gleixner <tglx@linutronix.de>:
> >> > On Wed, 11 Mar 2009, Akinobu Mita wrote:
> >> >> kmap_atomic_pfn() and iomap_atomic_prot_pfn() are almost same except
> >> >> pgprot. This patch removes the code duplication for these two functions.
> >> >
> >> > How exaclty does this compile with CONFIG_HIGHMEM=n ?
> >> >
> >>
> >> Oh, I didn't try without CONFIG_HIGHMEM.
> >
> > i had it applied in testing locally and didnt see problems so
> > far. Let me know if you can see any problems.
>
> It actually didn't compile with CONFIG_HIGHMEM=n as Thomas
> pointed out.
>
> arch/x86/mm/iomap_32.c:49: undefined reference to
> `kmap_atomic_prot_pfn'
hm, i didnt see any build failures myself. Could you please send
the .config that triggers it?
Ingo
next prev parent reply other threads:[~2009-03-12 12:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 14:33 [PATCH 1/2] x86: unify kmap_atomic_pfn() and iomap_atomic_prot_pfn() Akinobu Mita
2009-03-11 14:34 ` [PATCH 2/2] x86: debug check for kmap_atomic_pfn " Akinobu Mita
2009-03-11 16:54 ` [tip:x86/mm] " Akinobu Mita
2009-03-11 15:08 ` [PATCH 1/2] x86: unify kmap_atomic_pfn() " Thomas Gleixner
2009-03-11 15:25 ` Akinobu Mita
2009-03-11 16:52 ` Ingo Molnar
2009-03-12 0:28 ` Akinobu Mita
2009-03-12 12:24 ` Ingo Molnar [this message]
2009-03-12 12:27 ` Ingo Molnar
2009-03-11 16:54 ` [tip:x86/mm] " Akinobu Mita
2009-03-13 1:39 ` [tip:x86/mm] x86: unify kmap_atomic_pfn() and iomap_atomic_prot_pfn(), fix Ingo Molnar
2009-03-14 4:19 ` [PATCH -tip 1/2] mm: introduce debug_kmap_atomic Akinobu Mita
2009-03-14 4:20 ` [PATCH -tip 2/2] mm: use debug_kmap_atomic Akinobu Mita
2009-03-14 13:15 ` [PATCH -tip 1/2] mm: introduce debug_kmap_atomic Ingo Molnar
2009-03-15 15:15 ` Akinobu Mita
2009-03-15 20:45 ` [tip:x86/mm] x86, mm: remove unnecessary include file from iomap_32.c Akinobu Mita
2009-03-23 0:23 ` [PATCH -tip 1/2] mm: introduce debug_kmap_atomic Andrew Morton
2009-03-24 6:21 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090312122427.GA24295@elte.hu \
--to=mingo@elte.hu \
--cc=akinobu.mita@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox