From: David Brownell <david-b@pacbell.net>
To: "Wolfgang Mües" <wolfgang.mues@auerswald.de>
Cc: Pierre Ossman <drzeus@drzeus.cx>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Matt Fleming" <matt@console-pimps.org>,
"Mike Frysinger" <vapier.adi@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/7] mmc_spi: fix bug introduced in patch 3/7
Date: Thu, 12 Mar 2009 12:57:00 -0800 [thread overview]
Message-ID: <200903121357.00743.david-b@pacbell.net> (raw)
In-Reply-To: <200903121549.37620.wolfgang.mues@auerswald.de>
On Thursday 12 March 2009, Wolfgang Mües wrote:
> From: Wolfgang Muees <wolfgang.mues@auerswald.de>
>
> o Fix bug introduced in patch 3/7.
> The first 3 bits of the data response may be undefined;
> assuming that these bits are always 1 lead to unreliable
> transmission.
>
> Signed-off-by: Wolfgang Muees <wolfgang.mues@auerswald.de>
Could you just send an updated version of #3? Addressing
both this issue and the previous "comment is confusing" one.
I could ack such an update.
>
> ---
>
> diff -uprN 2_6_29_rc7_patch9_speedup/drivers/mmc/host/mmc_spi.c 2_6_29_rc7_patch10_bugfix_of_patch3/drivers/mmc/host/mmc_spi.c
> --- 2_6_29_rc7_patch9_speedup/drivers/mmc/host/mmc_spi.c 2009-03-12 14:35:27.000000000 +0100
> +++ 2_6_29_rc7_patch10_bugfix_of_patch3/drivers/mmc/host/mmc_spi.c 2009-03-12 14:40:03.000000000 +0100
> @@ -725,6 +725,9 @@ mmc_spi_writeblock(struct mmc_spi_host *
> pattern |= scratch->status[2] << 8;
> pattern |= scratch->status[3];
>
> + /* First 3 bit of pattern are undefined */
> + pattern |= 0xE0000000;
> +
> /* left-adjust to leading 0 bit */
> while (pattern & 0x80000000)
> pattern <<= 1;
>
> ---
> regards
>
> i. A. Wolfgang Mües
> --
> Auerswald GmbH & Co. KG
> Hardware Development
> Telefon: +49 (0)5306 9219 0
> Telefax: +49 (0)5306 9219 94
> E-Mail: Wolfgang.Mues@Auerswald.de
> Web: http://www.auerswald.de
>
> --------------------------------------------------------------
> Auerswald GmbH & Co. KG, Vor den Grashöfen 1, 38162 Cremlingen
> Registriert beim AG Braunschweig HRA 13289
> p.h.G Auerswald Geschäftsführungsges. mbH
> Registriert beim AG Braunschweig HRB 7463
> Geschäftsführer: Dipl-Ing. Gerhard Auerswald
>
>
next prev parent reply other threads:[~2009-03-12 20:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 14:49 [PATCH 10/7] mmc_spi: fix bug introduced in patch 3/7 Wolfgang Mües
2009-03-12 20:57 ` David Brownell [this message]
2009-03-15 11:48 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903121357.00743.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=drzeus@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=vapier.adi@gmail.com \
--cc=wolfgang.mues@auerswald.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox