feature-removal-schedule.txt for some I2C functions

feature-removal-schedule.txt for some I2C functions

[Mauro Carvalho Chehab]

Hi Jean,

On your entry at Documentation/feature-removal-schedule.txt:

What:   i2c_attach_client(), i2c_detach_client(), i2c_driver->detach_client()
When:   2.6.29 (ideally) or 2.6.30 (more likely)
Why:    Deprecated by the new (standard) device driver binding model. Use
        i2c_driver->probe() and ->remove() instead.
Who:    Jean Delvare <khali@linux-fr.org>

You forgot to add a check entry, like:
Check: i2c_attach_client i2c_detach_client i2c_driver->detach_client

The check entry is used by checkpatch.pl to warn about the usage of a legacy function.

Please fix it, since me and others rely on this tool to discover about the
usage of legacy functions.

Cheers,
Mauro

Re: feature-removal-schedule.txt for some I2C functions

[Jean Delvare]

Hi Mauro,

On Thu, 12 Mar 2009 10:26:17 -0300, Mauro Carvalho Chehab wrote:
> Hi Jean,
> 
> On your entry at Documentation/feature-removal-schedule.txt:
> 
> What:   i2c_attach_client(), i2c_detach_client(), i2c_driver->detach_client()
> When:   2.6.29 (ideally) or 2.6.30 (more likely)
> Why:    Deprecated by the new (standard) device driver binding model. Use
>         i2c_driver->probe() and ->remove() instead.
> Who:    Jean Delvare <khali@linux-fr.org>
> 
> You forgot to add a check entry, like:
> Check: i2c_attach_client i2c_detach_client i2c_driver->detach_client
> 
> The check entry is used by checkpatch.pl to warn about the usage of a legacy function.
> 
> Please fix it, since me and others rely on this tool to discover about the
> usage of legacy functions.

Thanks for the tip, I didn't know about this. Is there some
documentation about the Check: entry format? If checkpatch.pl simply
matches the strings then i2c_driver->detach_client is never going to
match, so there's no point in adding it.

-- 
Jean Delvare