From: Jason Baron <jbaron@redhat.com>
To: mingo@elte.hu, rostedt@goodmis.org
Cc: linux-kernel@vger.kernel.org, acme@ghostprotocols.net,
fweisbec@gmail.com, fche@redhat.com, peterz@infradead.org,
compudj@krystal.dyndns.org
Subject: [Patch 2/2] tracepoints for softirq entry/exit - tracepoints
Date: Thu, 12 Mar 2009 14:36:03 -0400 [thread overview]
Message-ID: <20090312183603.GC3352@redhat.com> (raw)
introduce softirq entry/exit tracepoints. These are useful for
augmenting existing tracers, and to figure out softirq frequencies and
timings.
Signed-off-by: Jason Baron <jbaron@redhat.com>
---
include/trace/irq_event_types.h | 12 ++++++++++++
kernel/softirq.c | 7 ++++++-
2 files changed, 18 insertions(+), 1 deletions(-)
diff --git a/include/trace/irq_event_types.h b/include/trace/irq_event_types.h
index 214bb92..38b4bdd 100644
--- a/include/trace/irq_event_types.h
+++ b/include/trace/irq_event_types.h
@@ -40,4 +40,16 @@ TRACE_EVENT(irq_handler_exit,
__entry->irq, __entry->ret ? "handled" : "unhandled")
);
+TRACE_FORMAT(irq_softirq_entry,
+ TP_PROTO(struct softirq_action *h, struct softirq_action *vec),
+ TP_ARGS(h, vec),
+ TP_FMT("softirq=%d action=%s", h - vec, softirq_to_name[h-vec])
+ );
+
+TRACE_FORMAT(irq_softirq_exit,
+ TP_PROTO(struct softirq_action *h, struct softirq_action *vec),
+ TP_ARGS(h, vec),
+ TP_FMT("softirq=%d action=%s", h - vec, softirq_to_name[h-vec])
+ );
+
#undef TRACE_SYSTEM
diff --git a/kernel/softirq.c b/kernel/softirq.c
index ba1511f..c378d53 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -24,6 +24,7 @@
#include <linux/ftrace.h>
#include <linux/smp.h>
#include <linux/tick.h>
+#include <trace/irq.h>
#include <asm/irq.h>
/*
@@ -186,6 +187,9 @@ EXPORT_SYMBOL(local_bh_enable_ip);
*/
#define MAX_SOFTIRQ_RESTART 10
+DEFINE_TRACE(irq_softirq_entry);
+DEFINE_TRACE(irq_softirq_exit);
+
asmlinkage void __do_softirq(void)
{
struct softirq_action *h;
@@ -212,8 +216,9 @@ restart:
if (pending & 1) {
int prev_count = preempt_count();
+ trace_irq_softirq_entry(h, softirq_vec);
h->action(h);
-
+ trace_irq_softirq_exit(h, softirq_vec);
if (unlikely(prev_count != preempt_count())) {
printk(KERN_ERR "huh, entered softirq %td %s %p"
"with preempt_count %08x,"
next reply other threads:[~2009-03-12 18:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 18:36 Jason Baron [this message]
2009-03-12 19:02 ` [Patch 2/2] tracepoints for softirq entry/exit - tracepoints Frederic Weisbecker
2009-03-12 23:49 ` Ingo Molnar
2009-03-13 4:03 ` [tip:tracing/ftrace] tracing: " Jason Baron
2009-03-14 2:57 ` [Patch 2/2] " Mathieu Desnoyers
2009-03-15 5:33 ` Ingo Molnar
2009-03-16 13:34 ` Steven Rostedt
2009-03-16 18:37 ` Mathieu Desnoyers
2009-03-16 18:45 ` Steven Rostedt
2009-03-16 18:51 ` Steven Rostedt
2009-03-16 19:28 ` Mathieu Desnoyers
2009-03-16 19:23 ` Mathieu Desnoyers
2009-03-16 19:00 ` Jason Baron
2009-03-16 19:17 ` Steven Rostedt
2009-03-16 19:21 ` Mathieu Desnoyers
2009-03-16 19:38 ` Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090312183603.GC3352@redhat.com \
--to=jbaron@redhat.com \
--cc=acme@ghostprotocols.net \
--cc=compudj@krystal.dyndns.org \
--cc=fche@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox