Re: [PATCH, RFC] sysfs: only allow one scheduled removal callback per kobj

Greg KH
2009-03-11T18:26:46Z

On Wed, Mar 11, 2009 at 06:47:29PM +0100, Cornelia Huck wrote:
> On Wed, 11 Mar 2009 08:32:28 -0700,
> Greg KH <gregkh@suse.de> wrote:
>
> > Why can't you use device_unregister()? Or, you could use device_del(),
> > which lets you rely on the fact that the device structure is still
> > around for a bit, but it will disappear from sysfs. Just don't forget
> > to do the final put_device() on it to free the memory and "really"
> > release it.
> >
> > Or am I missing something else here?
>
> You can't unregister a device from one of its attribute callbacks,

Doh! You're right, very sorry Alex for missing this.

> (For the original oops, I'd rather solve the problem by making sure the
> caller doesn't trigger removal several times - should probably be less
> code than the proposed patch?)

Any ideas on how to do this?

thanks,

greg k-h