From: Ingo Molnar <mingo@elte.hu>
To: David Newall <davidn@davidnewall.com>
Cc: Mike Galbraith <efault@gmx.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] (latest tip) make dequeue_task less confusing
Date: Fri, 13 Mar 2009 01:45:58 +0100 [thread overview]
Message-ID: <20090313004558.GD19544@elte.hu> (raw)
In-Reply-To: <49B94E43.6000405@davidnewall.com>
* David Newall <davidn@davidnewall.com> wrote:
> Mike Galbraith wrote:
> > Is there any real gain from doing this? It messes up the symmetry of
> > enqueue/dequeue.
>
>
> No. On further consideration, I don't like my patch.
With the __dequeue_task()+inline suggestion i made i think it
would be a micro-optimization and would not break symmetry in a
significant way.
Ingo
next prev parent reply other threads:[~2009-03-13 0:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 8:56 [PATCH] (latest tip) make dequeue_task less confusing David Newall
2009-03-12 9:55 ` Ingo Molnar
2009-03-12 13:36 ` Mike Galbraith
2009-03-12 18:02 ` David Newall
2009-03-13 0:45 ` Ingo Molnar [this message]
2009-03-13 3:58 ` David Newall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090313004558.GD19544@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=davidn@davidnewall.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox