From: Ingo Molnar <mingo@elte.hu>
To: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, trenn@suse.de,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH v2] x86: mtrr: don't modify RdDram/WrDram bits of fixed MTRRs
Date: Fri, 13 Mar 2009 02:58:56 +0100 [thread overview]
Message-ID: <20090313015856.GA18760@elte.hu> (raw)
In-Reply-To: <20090312163937.GH20716@alberich.amd.com>
* Andreas Herrmann <andreas.herrmann3@amd.com> wrote:
> Impact: bug fix + BIOS workaround
> Change to previous version:
> I slightly modified the log message (e.g. addition of FW_WARN).
>
> Please consider to apply this patch for .29.
i've applied it to tip:x86/mtrr, thanks Andreas.
I've add a -stable backport tag - so if it's problem-free it
should show up in .29.1.
It is not completely clear what the impact of this fix is. What
types of problems are such incoherent MTRR settings causing in
practice? Boot hang? S2RAM failures? Performance problems?
Without knowing the exact impact we cannot apply it this late in
the .29.0 cycle - and MTRR code change are dangerous in any case
so even if we knew the exact scope and impact we'd probably not
do it in .29.
Ingo
next prev parent reply other threads:[~2009-03-13 1:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 15:00 [PATCH] x86: mtrr: don't modify RdDram/WrDram bits of fixed MTRRs Andreas Herrmann
2009-03-12 8:01 ` Yinghai Lu
2009-03-12 11:41 ` Andreas Herrmann
2009-03-12 12:29 ` Maxim Levitsky
2009-03-12 12:53 ` Andreas Herrmann
2009-03-12 18:24 ` Yinghai Lu
2009-03-13 9:06 ` Andreas Herrmann
2009-03-12 16:39 ` [PATCH v2] " Andreas Herrmann
2009-03-13 1:58 ` Ingo Molnar [this message]
2009-03-13 8:42 ` Thomas Renninger
2009-03-13 9:18 ` Ingo Molnar
2009-03-13 10:08 ` How to submit patches that should be considered for stable inclusion also [Was: Re: [PATCH v2] x86: mtrr: ...] Thomas Renninger
2009-03-13 20:27 ` Greg KH
2009-03-13 9:04 ` [PATCH v2] x86: mtrr: don't modify RdDram/WrDram bits of fixed MTRRs Andreas Herrmann
2009-03-13 9:21 ` Ingo Molnar
2009-03-13 2:35 ` [tip:x86/mtrr] " Andreas Herrmann
2009-03-13 9:21 ` Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090313015856.GA18760@elte.hu \
--to=mingo@elte.hu \
--cc=andreas.herrmann3@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=trenn@suse.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox