From: Sam Ravnborg <sam@ravnborg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kyle McMartin <kyle@infradead.org>,
linux-kernel@vger.kernel.org, jakub@redhat.com,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] scripts/unifdef.c: rename getline symbol to something else
Date: Fri, 13 Mar 2009 06:52:09 +0100 [thread overview]
Message-ID: <20090313055209.GA18111@uranus.ravnborg.org> (raw)
In-Reply-To: <20090311235651.3c3fba2a.akpm@linux-foundation.org>
On Wed, Mar 11, 2009 at 11:56:51PM -0700, Andrew Morton wrote:
> On Wed, 11 Mar 2009 14:59:42 -0400 Kyle McMartin <kyle@infradead.org> wrote:
>
> > On Wed, Mar 11, 2009 at 07:37:35PM +0100, Sam Ravnborg wrote:
> > > > Rawhide builds are currently failing to build unifdef.c, as the next
> > > > version of glibc changes the default _POSIX_C_SOURCE level, which
> > > > exposes getline() from <stdio.h>
> > > >
> > > > scripts/unifdef.c:209: error: conflicting types for 'getline'
> > > > /usr/include/stdio.h:653: note: previous declaration of 'getline' was
> > > > here
> > > > make[2]: *** [scripts/unifdef] Error 1
> > > > make[1]: *** [__headers] Error 2
> > > > make: *** [vmlinux] Error 2
> > > >
> > > > Rename the symbol in unifdef.c to parseline to avoid this conflicting
> > > > declaration.
> > >
> > > I have a similar patch queued in kbuild-fixes.git.
> > >
> >
> > Great, thanks. Is this going to go into the next -rc?
> >
>
> I was going to put it into 2.6.29 but Sam stole it :)
Bad boy.
The patch is included in -rc8 so everyone is happy again.
Sam
next prev parent reply other threads:[~2009-03-13 5:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 16:17 [PATCH] scripts/unifdef.c: rename getline symbol to something else Kyle McMartin
2009-03-11 18:37 ` Sam Ravnborg
2009-03-11 18:59 ` Kyle McMartin
2009-03-12 6:56 ` Andrew Morton
2009-03-13 5:52 ` Sam Ravnborg [this message]
2009-03-13 5:51 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090313055209.GA18111@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=jakub@redhat.com \
--cc=kyle@infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox