From: Ben Dooks <ben@simtec.co.uk>
To: Daniel Mack <daniel@caiaq.de>
Cc: linux-net@vger.kernel.org, linux-kernel@vger.kernel.org,
Ben Dooks <ben@simtec.co.uk>
Subject: Re: [PATCH] drivers/net/ax88796.c: take IRQ flags from platform_device
Date: Fri, 13 Mar 2009 15:32:56 +0000 [thread overview]
Message-ID: <20090313153255.GG6295@trinity.fluff.org> (raw)
In-Reply-To: <1236955851-14763-1-git-send-email-daniel@caiaq.de>
On Fri, Mar 13, 2009 at 03:50:51PM +0100, Daniel Mack wrote:
> This patch adds support to the ax88796 ethernet driver to take IRQ flags
> given by the platform_device definition.
>
> The patch depends on the platform_get_irq_flags() function which I added
> in a patch posted here:
>
> http://lkml.org/lkml/2009/3/13/267
>
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> Cc: Ben Dooks <ben@simtec.co.uk>
Acked-by: Ben Dooks <ben-linux@fluff.org>
> ---
> drivers/net/ax88796.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c
> index a4eb6c4..728e17c 100644
> --- a/drivers/net/ax88796.c
> +++ b/drivers/net/ax88796.c
> @@ -93,6 +93,7 @@ struct ax_device {
>
> unsigned char running;
> unsigned char resume_open;
> + unsigned int irqflags;
>
> u32 reg_offsets[0x20];
> };
> @@ -474,7 +475,8 @@ static int ax_open(struct net_device *dev)
>
> dev_dbg(&ax->dev->dev, "%s: open\n", dev->name);
>
> - ret = request_irq(dev->irq, ax_ei_interrupt, 0, dev->name, dev);
> + ret = request_irq(dev->irq, ax_ei_interrupt, ax->irqflags,
> + dev->name, dev);
> if (ret)
> return ret;
>
> @@ -856,6 +858,7 @@ static int ax_probe(struct platform_device *pdev)
> goto exit_mem;
> }
> dev->irq = ret;
> + ax->irqflags = platform_get_irq_flags(pdev, 0);
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> if (res == NULL) {
> --
> 1.6.2
>
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
next prev parent reply other threads:[~2009-03-13 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-13 14:50 [PATCH] drivers/net/ax88796.c: take IRQ flags from platform_device Daniel Mack
2009-03-13 15:32 ` Ben Dooks [this message]
2009-03-13 18:53 ` David Miller
2009-03-13 19:02 ` David Miller
2009-03-13 19:10 ` Matti Aarnio
2009-03-15 11:27 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090313153255.GG6295@trinity.fluff.org \
--to=ben@simtec.co.uk \
--cc=daniel@caiaq.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox