From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758755AbZCMQSa (ORCPT ); Fri, 13 Mar 2009 12:18:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752287AbZCMQSV (ORCPT ); Fri, 13 Mar 2009 12:18:21 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:40653 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754599AbZCMQSU (ORCPT ); Fri, 13 Mar 2009 12:18:20 -0400 Date: Fri, 13 Mar 2009 17:17:49 +0100 From: Ingo Molnar To: Frederic Weisbecker Cc: Linux Kernel Mailing List , Peter Zijlstra , Steven Rostedt , tglx@linutronix.de, Jason Baron , "Frank Ch. Eigler" , Mathieu Desnoyers , KOSAKI Motohiro , Lai Jiangshan , Jiaying Zhang , Michael Rubin , Martin Bligh , Michael Davidson Subject: Re: [PATCH 0/2 v2] Syscalls tracing Message-ID: <20090313161749.GA3203@elte.hu> References: <1236955332-10133-1-git-send-email-fweisbec@gmail.com> <20090313151632.GB9867@nowhere> <20090313155541.GA15481@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090313155541.GA15481@elte.hu> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Ingo Molnar wrote: > > * Frederic Weisbecker wrote: > > > On Fri, Mar 13, 2009 at 03:42:10PM +0100, Frederic Weisbecker wrote: > > > tracing/syscalls: core infrastructure to trace syscalls > > > > > > This new iteration addresses a good part of the previous reviews. > > > > > > Ah I just discovered that you applied the previous version > > today. But the v2 is not a delta :-s > > > > I can rebase them but not until Sunday. > > No problem, i'll deltify them and will have a look. Ok, i did the deltas, tidied them up and put them into tip:tracing/syscalls. Nice stuff! Here's some sample output: aldebaran:/debug/tracing> head trace # tracer: syscall # # TASK-PID CPU# TIMESTAMP FUNCTION # | | | | | <...>-4405 [003] 188.452934: sys_dup2(oldfd: a, newfd: 1) <...>-4405 [003] 188.452939: sys_dup2 -> 0x1 <...>-4405 [003] 188.452940: sys_fcntl(fd: a, cmd: 1, arg: 0) <...>-4405 [003] 188.452941: sys_fcntl -> 0x1 <...>-4405 [003] 188.452942: sys_close(fd: a) <...>-4405 [003] 188.452943: sys_close -> 0x0 A suggestion: - Would be nice for all the registered syscalls to show up under /debug/events/syscalls/, one directory per syscall, with an 'enable' and a 'format' file as well. And a bugreport: - when using function_graph (after having used the syscall tracer) i dont see graph traces anymore - only the syscall trace entries: # tracer: function_graph # # CPU DURATION FUNCTION CALLS # | | | | | | | ##### CPU 9 buffer started #### at-spi-registry-3063 [009] 322.915058: sys_read -> 0x5a8 at-spi-registry-3063 [009] 322.915059: sys_write(fd: 6, buf: 632840, count: 5a8) at-spi-registry-3063 [009] 322.915062: sys_write -> 0x5a8 at-spi-registry-3063 [009] 322.915062: sys_read(fd: 4, buf: 632840, count: 40000) That's not intended, right? Ingo